Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: textual and binary importer ignore //go:nointerface pragma #16243

Closed
griesemer opened this issue Jul 1, 2016 · 1 comment
Closed

cmd/compile: textual and binary importer ignore //go:nointerface pragma #16243

griesemer opened this issue Jul 1, 2016 · 1 comment
Labels
FrozenDueToAge
Milestone
Go1.7

Comments

@griesemer
Copy link
Contributor

This bug was introduced by https://go-review.googlesource.com/19966 (parser.go):

In https://go-review.googlesource.com/#/c/19966/3/src/cmd/compile/internal/gc/parser.go, line 2061 on the left still respects nointerface, while the new line 2057 simply sets it to false. As a result, the further translation to the binary format doesn't know about it either.

This is a regression and needs to be fixed for 1.7.

cc: @ianlancetaylor
@griesemer griesemer added this to the Go1.7 milestone Jul 1, 2016
@griesemer griesemer self-assigned this Jul 1, 2016
@gopherbot
Copy link

CL https://golang.org/cl/24648 mentions this issue.

@mdempsky mdempsky mentioned this issue Jul 1, 2016
Open
@golang golang locked and limited conversation to collaborators Jul 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.7
Development

No branches or pull requests
2 participants
@griesemer @gopherbot