Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: delete TestCondCopy? #16229

Closed
josharian opened this issue Jun 30, 2016 · 2 comments
Closed

sync: delete TestCondCopy? #16229

josharian opened this issue Jun 30, 2016 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.8

Comments

@josharian
Copy link
Contributor

It appears to be testing copying a lock, which people shouldn't do.

func TestCondCopy(t *testing.T) {
    defer func() {
        err := recover()
        if err == nil || err.(string) != "sync.Cond is copied" {
            t.Fatalf("got %v, expect sync.Cond is copied", err)
        }
    }()
    c := Cond{L: &Mutex{}}
    c.Signal()
    c2 := c
    c2.Signal()
}

Vet doesn't like it:

sync/cond_test.go:254: assignment copies lock value to c2: sync.Cond contains sync.noCopy

Objections to it being deleted for 1.8?

cc @dvyukov

Part of dealing with #11041.
@josharian josharian added this to the Go1.8 milestone Jun 30, 2016
@josharian josharian self-assigned this Jun 30, 2016
@dvyukov
Copy link
Member

dvyukov commented Jun 30, 2016

It appears to be testing copying a lock, which people shouldn't do.

The mutex is not copied here. Cond contains a pointer to the mutex. But Cond itself should not be copied.

The test tests a useful property. Not all use vet. Cond detects the misuse reliably at runtime. Can we move it to _novet.go or something?

@josharian
Copy link
Contributor Author

Ok, thanks. I'll figure out a way to add an exception for it as part of #11041 -- it's not going to be the only exception.

@golang golang locked and limited conversation to collaborators Jun 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.8
Development

No branches or pull requests
3 participants
@josharian @dvyukov @gopherbot