Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/present: slides.js not running on safari #16216

Closed
glorieux opened this issue Jun 29, 2016 · 2 comments
Closed

x/tools/cmd/present: slides.js not running on safari #16216

glorieux opened this issue Jun 29, 2016 · 2 comments
Labels
FrozenDueToAge

Comments

@glorieux
Copy link

  1. What version of Go are you using (go version)?
    go version go1.5 darwin/amd64
  2. What operating system and processor architecture are you using (go env)?
    GOARCH="amd64"
    GOBIN=""
    GOEXE=""
    GOHOSTARCH="amd64"
    GOHOSTOS="darwin"
    GOOS="darwin"
    GOPATH="/Users/glorieux/Workspace/gocode"
    GORACE=""
    GOROOT="/usr/local/go"
    GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
    GO15VENDOREXPERIMENT=""
    CC="clang"
    GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fno-common"
    CXX="clang++"
    CGO_ENABLED="1"
  3. What did you do?
    Install present.
    Create a really simple slide presentation.
    Run present
    Open Safari.
  4. What did you expect to see?
    I expected the slides to display on Safari.
  5. What did you see instead?
    It did not display and raised the following error on the console: SyntaxError: Unexpected identifier 'i'. Expected either 'in' or 'of' in enumeration syntax. (anonymous function)slides.js:540
  6. Fix
    Since Safari is not yet supporting ES6 let statements they need to be replaced by var ones.

Looks like the bug was introduced by https://go-review.googlesource.com/21488
@binary132
Copy link

binary132 commented Jul 1, 2016 •
edited

I confirm this is affecting me and other users of my hosted slides with latest present.

@gopherbot
Copy link

CL https://golang.org/cl/24721 mentions this issue.

jjneely pushed a commit to jjneely/present that referenced this issue Nov 4, 2016
@glorieux @adg
x/tools/cmd/present: Fix present not working on Safari
6344668 
As described on golang/go#16216 present is not
currently working on Safari because of the use of ES6 JavaScript let
statements.
The solution is to use var statements instead of let.

Fixes golang/go#16216

Change-Id: I44c84f920aa41dfc8de5997ab50a440de6d57093
Reviewed-on: https://go-review.googlesource.com/24721
Reviewed-by: Andrew Gerrand <adg@golang.org>
@golang golang locked and limited conversation to collaborators Jul 3, 2017
@rsc rsc unassigned campoy and adg Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@glorieux @binary132 @campoy @adg @gopherbot