Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: PPC64 SSA support #16175

Closed
laboger opened this issue Jun 24, 2016 · 8 comments
Closed

cmd/compile: PPC64 SSA support #16175

laboger opened this issue Jun 24, 2016 · 8 comments
Milestone

Comments

@laboger
Copy link
Contributor

laboger commented Jun 24, 2016

Please answer these questions before submitting your issue. Thanks!

  1. What version of Go are you using (go version)?
    master ssa branch
  2. What operating system and processor architecture are you using (go env)?
    ppc64le Ubuntu
  3. What did you do?
    If possible, provide a recipe for reproducing the error.
    A complete runnable program is good.
    A link on play.golang.org is best.
    Initial implementation of SSA for GOARCH ppc64le, possibly ppc64
  4. What did you expect to see?
    Correct implementation of ssa on ppc64le as a basis for future ongoing optimizations.
  5. What did you see instead?
    Work in progress....
@laboger
Copy link
Contributor Author

laboger commented Jun 24, 2016

Keith answered my question first so I went with what he recommended. I don't think he explicitly said to open an issue but that's what I've done in the past so I did and I like to have a place to ask questions.

I submitted what I have so far. It builds and all tests pass when running ./all.bash. I can build hello.go using SSATEST=yes without error but it doesn't run! (nothing gets printed).

@dr2chase

I think there was a question at one time if it should be both ppc64le & ppc64 but ppc64le is more important so if that is done first, that is fine. Unless the plan is to move all GOARCHes to SSA?

https://go-review.googlesource.com/24453

@gopherbot
Copy link

CL https://golang.org/cl/24453 mentions this issue.

@dr2chase
Copy link
Contributor

Plan is to move all GOARCHes to SSA. Not quite sure how we're organizing PPC64le vs PPC64be, but agreed le is more important. I'm looking at the CL, I'm inclined to LGTM it permissively because it's a great start. Still working on my own PPCle access (can log in, have no home dir, might complicate use of tool chain).

@laboger
Copy link
Contributor Author

laboger commented Oct 6, 2016

@drchase OK to close this? Or are we still waiting/deciding on PPC64 BE?

@dr2chase
Copy link
Contributor

dr2chase commented Oct 6, 2016

Seems closeable to me, not sure what the exact PPC64 BE build+test story is (haven't paid close attention to the builders lately).

@bradfitz
Copy link
Contributor

bradfitz commented Oct 6, 2016

@dr2chase, we just got the ppc64 BE builders yesterday. I'll try to set them up now.

@bradfitz
Copy link
Contributor

bradfitz commented Oct 6, 2016

Builders are now online.

@bradfitz
Copy link
Contributor

bradfitz commented Oct 6, 2016

With @ianlancetaylor's fix to #17361, we have our first "ok" on the dashboard. Closing this.

@bradfitz bradfitz closed this as completed Oct 6, 2016
@golang golang locked and limited conversation to collaborators Oct 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants