Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/gofmt: indent comments in otherwise-empty slice, array, and map literals #16140

Closed
cespare opened this issue Jun 21, 2016 · 1 comment
Closed

cmd/gofmt: indent comments in otherwise-empty slice, array, and map literals #16140

cespare opened this issue Jun 21, 2016 · 1 comment
Labels
FrozenDueToAge
Milestone
Unplanned

Comments

@cespare
Copy link
Contributor

cespare commented Jun 21, 2016

Go 1.6.2.

https://play.golang.org/p/fegoJJL-BQ shows a gofmt corner case that seems a little inconsistent. I'd expect the lines marked with <-- indent? to be indented, as they would be if any elements were added into the slice/map literals.

Low priority.

/cc @griesemer
@cespare cespare changed the title cmd/gofmt: Indent comments in otherwise-empty slice, array, and map literals cmd/gofmt: indent comments in otherwise-empty slice, array, and map literals Jun 21, 2016
@griesemer griesemer self-assigned this Jun 21, 2016
@griesemer griesemer added this to the Unplanned milestone Jun 21, 2016
@cespare
Copy link
Contributor Author

cespare commented Apr 25, 2019

Seems like this was fixed in Go 1.10. 🎉

@cespare cespare closed this as completed Apr 25, 2019
@golang golang locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
3 participants
@cespare @griesemer @gopherbot