You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
tls.DialWithDialer copies the passed in tls.Config if Config.ServerName is not set, but does not exclude copying the unexported sync.Once: tls.go:138.
DialWithDialer should use something like cloneTLSClientConfig from net/http. Related to #15771, which proposes implementing a Clone method on Config, which would help here.
This fixes some 40 warnings from go vet.
Fixesgolang#16134.
Change-Id: Ib9fcba275fe692f027a2a07b581c8cf503b11087
Reviewed-on: https://go-review.googlesource.com/24287
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
This fixes some 40 warnings from go vet.
Fixesgolang#16134.
Change-Id: Ib9fcba275fe692f027a2a07b581c8cf503b11087
Reviewed-on: https://go-review.googlesource.com/24287
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
tls.DialWithDialer copies the passed in tls.Config if Config.ServerName is not set, but does not exclude copying the unexported sync.Once: tls.go:138.
DialWithDialer should use something like cloneTLSClientConfig from net/http. Related to #15771, which proposes implementing a Clone method on Config, which would help here.
CC @GeoffreyPlouviez who found the bug originally.
The text was updated successfully, but these errors were encountered: