Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http2: flaky TestTransportReqBodyAfterResponse_403 #16102

Closed
mikioh opened this issue Jun 18, 2016 · 3 comments
Closed

x/net/http2: flaky TestTransportReqBodyAfterResponse_403 #16102

mikioh opened this issue Jun 18, 2016 · 3 comments
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@mikioh
Copy link
Contributor

mikioh commented Jun 18, 2016

See https://build.golang.org/log/e59465cf2e0b92444c0598c3a4d813353f3e53d9 and https://build.golang.org/log/ae3a78dd1d3ac52f57795918af38fb43cfe0aa59

--- FAIL: TestTransportReqBodyAfterResponse_403 (0.05s)
    transport_test.go:664: client: RoundTrip: http2: stream closed
FAIL
FAIL    golang.org/x/net/http2  13.922s
@mikioh mikioh added this to the Go1.7Maybe milestone Jun 18, 2016
@ianlancetaylor ianlancetaylor added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jun 20, 2016
@gopherbot
Copy link

CL https://golang.org/cl/24903 mentions this issue.

@bradfitz bradfitz modified the milestones: Unreleased, Go1.7Maybe Jul 15, 2016
gopherbot pushed a commit to golang/net that referenced this issue Jul 15, 2016
@bradfitz
http2: fix flaky TestTransportReqBodyAfterResponse_403
c9a3c54 
Removes a time.Sleep from a test.

Fixes golang/go#16102

Change-Id: Ic1079ad3312d2dcfde4cc16dd0ee9661e1e509f2
Reviewed-on: https://go-review.googlesource.com/24903
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
@bradfitz
Copy link
Contributor

Not fixed:
https://build.golang.org/log/56e0561f9f6a740b75538692a1c3288f08949dd0

I have the real fix.

@bradfitz bradfitz reopened this Jul 16, 2016
@gopherbot
Copy link

CL https://golang.org/cl/24984 mentions this issue.

@golang golang locked and limited conversation to collaborators Jul 17, 2017
c3mb0 pushed a commit to c3mb0/net that referenced this issue Apr 2, 2018
@bradfitz
http2: fix flaky TestTransportReqBodyAfterResponse_403
d6aff4a 
Removes a time.Sleep from a test.

Fixes golang/go#16102

Change-Id: Ic1079ad3312d2dcfde4cc16dd0ee9661e1e509f2
Reviewed-on: https://go-review.googlesource.com/24903
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
c3mb0 pushed a commit to c3mb0/net that referenced this issue Apr 2, 2018
@bradfitz
http2: make Transport prefer HTTP response header recv before body wr…
e325faf 
…ite error

Fixes flakes like:
https://build.golang.org/log/56e0561f9f6a740b75538692a1c3288f08949dd0

I reproduced the flake above with a time.Sleep(50 * time.Millisecond)
before ClientConn.RoundTrip's final for{select{...}} loop (to give
multiple channels time to become readable on the first select), and
then ran (on linux/amd64) with:

go test -v -run=TestTransportReqBodyAfterResponse_403 -count=50 -race

Before, many failed. With this CL it never fails. (crosses fingers)

Fixes golang/go#16102 (again)

Change-Id: I93fde46846cd09445e53c140e9668382965d95c5
Reviewed-on: https://go-review.googlesource.com/24984
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Gerrand <adg@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @mikioh @ianlancetaylor @gopherbot