New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syscall: skip TestUnshare if kernel does not support net namespace #16056
Comments
I will look into it! On Mon, Jun 13, 2016 at 12:12 PM Austin Clements notifications@github.com
|
To clarify, this test is actually not flaky. The builder tasks are scheduled onto three machines, two of which do not run with root, so this test is skipped there. I just ran it on these two machines manually with root, it constantly passes on one machine while constantly fails on the other. strace on the failure machine shows
Maybe kernel configuration (The machines may have different kernel configurations)? Is there something I can check? |
It seems it is |
If the test fails when some kernel configuration is missing, then we should check that and skip the test when it won't pass. We shouldn't rely on Go users recompiling their kernel in order to pass a test. |
CL https://golang.org/cl/24132 mentions this issue. |
TestUnshare has been failing 22% of the time on the mips64le builder since May 20th. The most recent failure is https://build.golang.org/log/3bcf1e559a0fe0e05f036f425912a59b99aeeda3. This was probably the fault of commit 1ded9fd: "syscall: fix unshare test on mips", though maybe that just exposed an existing bug.
/cc @cherrymui @jfrazelle
The text was updated successfully, but these errors were encountered: