x/sys/unix: arm64 does not have poll #16052
Comments
|
Breaking commit is https://golang.org/cl/23661. I suspect that on ARM64 GNU/Linux we need to use ppoll, which will require converting the timeout field. CC @kortschak |
ianlancetaylor
changed the title
|
Using ppoll in place of poll for the ARM64 linux blocks later addition of Ppoll to sys which may be required. Maybe just remove Poll from the ARM64 linux code? What is the best way to leave this? |
|
I'm not sure if x/sys is the place to have the shim translating poll to ppoll... I'd be ok with removing it on arm64 I think. |
|
What is preferable? Upgrading all to Ppoll or removing Poll from arm64. |
|
I think it is most useful to implement Poll on arm64 by having it call Ppoll. That is what we have done for system calls like Stat, Lchown, Dup2, InotifyInit, etc. |
|
While I'm there should I add ppoll to the other arches?
|
That would be great if you feel like doing it. |
|
CL https://golang.org/cl/24062 mentions this issue. |
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
go version)?go1.6.1 and go 1.6.2
What operating system and processor architecture are you using (
go env)?GOARCH="arm64"
GOHOSTARCH="arm64"
GOHOSTOS="linux"
GOOS="linux"
What did you do?
go get golang.org/x/sys/unix
What did you expect to see?
Successful completion
What did you see instead?
golang.org/x/sys/unix
src/golang.org/x/sys/unix/zsyscall_linux_arm64.go:57: undefined: SYS_POLL
Looks like 7f918dd in https://github.com/golang/sys broke arm64 builds
The text was updated successfully, but these errors were encountered: