New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/review/git-codereview: support mailing multiple revisions with a single CL #16034
Comments
Never mind. I'm an idiot. Can't believe it has taken me how long?? to figure out that I can just git mail the topmost commit. Sigh. |
You're not an idiot @josharian. |
CL welcome! |
Keep this open as it's a valid issue. |
I also completely failed to understand that this is how it's supposed to be used. Here's a question - why shouldn't |
That sounds good to me. Alternatively I’d be happy enough with a better error message and accepting any git ref (eg “head”). |
Wait a minute, but
Do we want to make |
@ysmolsky that's one of the suggestions made above. The other suggestion is for |
Change https://golang.org/cl/148137 mentions this issue: |
This was fixed by the CL. |
"mail HEAD" will mail every commit between HEAD and branching point. Fixes golang/go#16034 Change-Id: If95aece584f2a324f866c64770f7361ddb3e7636 Reviewed-on: https://go-review.googlesource.com/c/review/+/148137 Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
I will now proceed to run
git mail
individually on every single commit, in order, manually copying and pasting in the SHA1s. This happens all the time, at least for me. I'd like to be able to tellgit mail
to mail all of them, re-using the other flags (reviewer, trybot) for every commit:Maybe:
@adg, opinions?
The text was updated successfully, but these errors were encountered: