New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: PowerPC (LE) SSA support #16010
Comments
Runs fibonacci for all integer types. Fold addressing arithmetic into stores. Updates #16010. Change-Id: I257982c82c00c80b00679757c3da345045968022 Reviewed-on: https://go-review.googlesource.com/25103 Reviewed-by: Cherry Zhang <cherryyz@google.com> Run-TryBot: David Chase <drchase@google.com>
CL https://golang.org/cl/25151 mentions this issue. |
Because PPC lacks store-immediate, remove the instruction that implies that it exists. Replace it with storezero for the special case of storing zero, because R0 is reserved zero for Go (though the assembler knows this, do it in SSA). Also added address folding for storezero. (Now corrected to use right-sized stores in bulk-zero code.) Hello.go now compiles to genssa main 00000 (...hello.go:7) TEXT "".main(SB), $0 00001 (...hello.go:7) FUNCDATA $0, "".gcargs·0(SB) 00002 (...hello.go:7) FUNCDATA $1, "".gclocals·1(SB) v23 00003 (...hello.go:8) MOVD $go.string."Hello, World!\n"(SB), R3 v11 00004 (...hello.go:8) MOVD R3, 32(R1) v22 00005 (...hello.go:8) MOVD $14, R3 v6 00006 (...hello.go:8) MOVD R3, 40(R1) v20 00007 (...hello.go:8) MOVD R0, 48(R1) v18 00008 (...hello.go:8) MOVD R0, 56(R1) v9 00009 (...hello.go:8) MOVD R0, 64(R1) v10 00010 (...hello.go:8) CALL fmt.Printf(SB) b2 00011 (...hello.go:9) RET 00012 (<unknown line number>) END Updates #16010 Change-Id: I33cfd98c21a1617502260ac753fa8cad68c8d85a Reviewed-on: https://go-review.googlesource.com/25151 Reviewed-by: Cherry Zhang <cherryyz@google.com> Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
…laneous" Added support for ClosureCall, DeferCall, InterCall (GoCall not yet tested). Added support for GetClosurePtr, IsNonNil, IsInBounds, IsSliceInBounds, NilCheck (Convert and GetG not yet tested) Still need to implement NilCheck optimizations. Fixed move boolean constant, order of operands to subtract. Updates #16010. Change-Id: Ibe0f6a6e688df4396cd77de0e9095997e4ca8ed2 Reviewed-on: https://go-review.googlesource.com/25241 Reviewed-by: Cherry Zhang <cherryyz@google.com> Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
CL https://golang.org/cl/25310 mentions this issue. |
Passes light testing. Modified to avoid possible exposure of "exterior" pointers to GC. Updates #16010. Change-Id: I41fced4fa83cefb9542dff8c8dee1a0c48056b3c Reviewed-on: https://go-review.googlesource.com/25310 Reviewed-by: Cherry Zhang <cherryyz@google.com> Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
CL https://golang.org/cl/25493 mentions this issue. |
…bools Updates #16010. Change-Id: Ie520d64fd1c4f881f45623303ed0b7cbdf0e4764 Reviewed-on: https://go-review.googlesource.com/25493 Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
CL https://golang.org/cl/25589 mentions this issue. |
FP<->int conversions remain. Updates #16010. Change-Id: I38d7a4923e34d0a489935fffc4c96c020cafdba2 Reviewed-on: https://go-review.googlesource.com/25589 Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org>
CL https://golang.org/cl/26813 mentions this issue. |
Passes ssa_test. Requires a few new instructions and some scratchpad memory to move data between G and F registers. Also fixed comparisons to be correct in case of NaN. Added missing instructions for run.bash. Removed some FP registers that are apparently "reserved" (but that are also apparently also unused except for a gratuitous multiplication by two when y = x+x would work just as well). Currently failing stack splits. Updates #16010. Change-Id: I73b161bfff54445d72bd7b813b1479f89fc72602 Reviewed-on: https://go-review.googlesource.com/26813 Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
CL https://golang.org/cl/27159 mentions this issue. |
This time with the cherry-pick from the proper patch of the old CL. Stack size increased. Corrected NaN-comparison glitches. Marked g register as clobbered by calls. Fixed shared libraries. live_ssa.go still disabled because of differences. Presumably turning on more optimization will fix both the stack size and the live_ssa.go glitches. Enhanced debugging output for shared libs test. Rebased onto master. Updates #16010. Change-Id: I40864faf1ef32c118fb141b7ef8e854498e6b2c4 Reviewed-on: https://go-review.googlesource.com/27159 Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
CL https://golang.org/cl/27511 mentions this issue. |
David, should we close this? |
Depends -- there's a fair amount of optimization yet to do (e.g., nil On Fri, Aug 26, 2016 at 4:51 PM, Keith Randall notifications@github.com
|
Ok. I'm happy to close this bug when we reach parity with the old compiler. We don't need to be finished all the optimizations to declare success. |
CL https://golang.org/cl/28548 mentions this issue. |
Enabled checks (except for DUFF-ops which aren't implemented yet). Added ppc64le to relevant test. Also updated register list to reflect no-longer-reserved- for-constants status (file was missed in that change). Updates #16010. Change-Id: I31b1aac19e14994f760f2ecd02edbeb1f78362e7 Reviewed-on: https://go-review.googlesource.com/28548 Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
I'd say this is done. Closing. File new bugs as needed. |
No description provided.
The text was updated successfully, but these errors were encountered: