cmd/compile: internal compiler error on test -race #16008
Description
Please answer these questions before submitting your issue. Thanks!
- What version of Go are you using (
go version)?
go version devel +3c6b668 Thu Jun 2 00:22:03 2016 +0000 linux/amd64 (it's go1.7beta1) - What operating system and processor architecture are you using (
go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/moroz/project/workspace"
GORACE=""
GOROOT="/home/moroz/go"
GOTOOLDIR="/home/moroz/go/pkg/tool/linux_amd64"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build360617198=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
- What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
go test -race github.com/docker/swarmkit/manager/state/store
- What did you expect to see?
Tests just passing - What did you see instead?
Compilation fails with
# github.com/docker/swarmkit/manager/state/store
manager/state/store/memory_test.go:1177: internal compiler error: Treating auto as if it were arg, func BenchmarkUpdateNodeTransaction.func1, node autotmp_2905, value v264
goroutine 1 [running]:
runtime/debug.Stack(0x0, 0x0, 0x0)
/home/moroz/go/src/runtime/debug/stack.go:24 +0x79
cmd/compile/internal/gc.Fatalf(0x907f5d, 0x3b, 0xc422bb5680, 0x3, 0x3)
/home/moroz/go/src/cmd/compile/internal/gc/subr.go:165 +0x248
cmd/compile/internal/gc.(*ssaExport).Fatalf(0xb58186, 0xd35, 0x907f5d, 0x3b, 0xc422bb5680, 0x3, 0x3)
/home/moroz/go/src/cmd/compile/internal/gc/ssa.go:4426 +0x74
cmd/compile/internal/ssa.(*Config).Fatalf(0xc4218ae000, 0xc400000d35, 0x907f5d, 0x3b, 0xc422bb5680, 0x3, 0x3)
/home/moroz/go/src/cmd/compile/internal/ssa/config.go:200 +0x6e
cmd/compile/internal/gc.(*state).Fatalf(0xc422b8cd80, 0x907f5d, 0x3b, 0xc422bb5680, 0x3, 0x3)
/home/moroz/go/src/cmd/compile/internal/gc/ssa.go:336 +0x83
cmd/compile/internal/gc.(*state).resolveFwdRef(0xc422b8cd80, 0xc4218b5408, 0x0)
/home/moroz/go/src/cmd/compile/internal/gc/ssa.go:3801 +0x587
cmd/compile/internal/gc.(*state).linkForwardReferences(0xc422b8cd80, 0x0)
/home/moroz/go/src/cmd/compile/internal/gc/ssa.go:3786 +0x6e
cmd/compile/internal/gc.buildssa(0xc4216ef7a0, 0x0)
/home/moroz/go/src/cmd/compile/internal/gc/ssa.go:221 +0x93a
cmd/compile/internal/gc.compile(0xc4216ef7a0)
/home/moroz/go/src/cmd/compile/internal/gc/pgen.go:405 +0x1363
cmd/compile/internal/gc.funccompile(0xc4216ef7a0)
/home/moroz/go/src/cmd/compile/internal/gc/dcl.go:1287 +0x186
cmd/compile/internal/gc.Main()
/home/moroz/go/src/cmd/compile/internal/gc/main.go:465 +0x19af
cmd/compile/internal/amd64.Main()
/home/moroz/go/src/cmd/compile/internal/amd64/galign.go:93 +0x2fa
main.main()
/home/moroz/go/src/cmd/compile/main.go:33 +0x2a3
FAIL github.com/docker/swarmkit/manager/state/store [build failed]
Sorry for numeration :/ I dunno how to fix markdown
UPD in case if master will change, here is hash of commit f338afd2303f1f25a3ba8bf50a35d85b0cc5aacc
Metadata
Metadata
Assignees
Type
Projects
Relationships
Development
No branches or pull requests
Participants
Activity
[-]Internal compiler error on test -race[/-][+]cmd/compile: internal compiler error on test -race[/+]ianlancetaylor commentedon Jun 8, 2016
CC @randall77 @josharian
dr2chase commentedon Jun 8, 2016
Reproduces nicely for me (after a go get). No idea of the root cause (yet) though I added that error message (it means "uninitialized autotmp in the entry block, this won't get better if we continue compiling").
josharian commentedon Jun 8, 2016
@dr2chase since you have it set up already, want to bisect?
dr2chase commentedon Jun 8, 2016
Sure. I'm sitting in a talk anyhow right now...
dr2chase commentedon Jun 8, 2016
Sigh.
20803b8 cmd/compile: eliminate PPARAMREF
dr2chase commentedon Jun 8, 2016
For comparison, here's the input to SSA from the last good and first bad revisions, for the problematic function, with trailing irrelevant output trimmed off:
GOSSAFUNC=BenchmarkUpdateNodeTransaction.func1 go test -race github.com/docker/swarmkit/manager/state/store >& good_or_bad.txtbad.txt
good.txt
dr2chase commentedon Jun 9, 2016
I have what looks like a likely fix, more later, need to also make a tiny test case.
gopherbot commentedon Jun 10, 2016
CL https://golang.org/cl/23954 mentions this issue.
dr2chase commentedon Jun 10, 2016
See also #15091
Very related (same error, for OAS, not OASWB).
Possibly all nodes should be treated in the "improved" way.
LK4D4 commentedon Jun 13, 2016
@dr2chase thanks!