Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestRepoRootForImportPath fails #15979

Closed
josharian opened this issue Jun 6, 2016 · 5 comments
Closed

cmd/go: TestRepoRootForImportPath fails #15979

josharian opened this issue Jun 6, 2016 · 5 comments
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.7

Comments

@josharian
Copy link
Contributor

At tip:

$ go test cmd/go
--- FAIL: TestRepoRootForImportPath (0.92s)
    vcs_test.go:159: RepoRootForImport("git.openstack.org/openstack/swift.git"): invalid version control suffix in git.openstack.org path
FAIL
FAIL    cmd/go  207.939s

This test doesn't run in -short mode, which is probably why no one noticed. (We could really use a builder that runs the full tests.)
@josharian josharian added this to the Go1.7Maybe milestone Jun 6, 2016
@adg adg modified the milestones: Go1.7, Go1.7Maybe Jun 6, 2016
@ianlancetaylor
Copy link
Contributor

As far as I can see, this test has been broken since it was submitted in https://golang.org/cl/23135, but nobody noticed because the test does not run with -test.short as used on the builders.

I asked on the CL what the intent is.

@ianlancetaylor ianlancetaylor added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jun 13, 2016
@emonty
Copy link
Contributor

emonty commented Jun 14, 2016

Bother. I'll jump on this right away - sorry.

@josharian
Copy link
Contributor Author

Any status update, @emonty?

@adg adg self-assigned this Jun 27, 2016
@gopherbot
Copy link

CL https://golang.org/cl/24645 mentions this issue.

@adg
Copy link
Contributor

adg commented Jul 3, 2016

Should be fixed by afccfb8.

@adg adg closed this as completed Jul 3, 2016
gopherbot pushed a commit that referenced this issue Jul 4, 2016
@emonty @adg
cmd/go: remove noVCSSuffix check for OpenStack
afccfb8 
The original intent of the code was to allow both with and without .git
suffix for now to allow a transition period. The noVCSSuffix check was a
copy pasta error.

Fixes #15979.

Change-Id: I3d39aba8d026b40fc445244d6d01d8bc1979d1e4
Reviewed-on: https://go-review.googlesource.com/24645
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@josharian josharian mentioned this issue Oct 25, 2016
Closed
@golang golang locked and limited conversation to collaborators Jul 3, 2017
@rsc rsc unassigned adg Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.7
Development

No branches or pull requests
5 participants
@josharian @emonty @ianlancetaylor @adg @gopherbot