net/http: Serve violates tls.Config immutability promise #15908
Labels
Milestone
Comments
|
This might be a dup of Issue #15771 |
|
I'm not sure what, if anything, can be done about this before the 1.7 release. |
|
CL https://golang.org/cl/24508 mentions this issue. |
gopherbot
pushed a commit
that referenced
this issue
Aug 2, 2016
Fixes #16550 Updates #15908 Change-Id: Ic951080dbc88f96e4c00cdb3ffe24a5c03079efd Reviewed-on: https://go-review.googlesource.com/25389 Reviewed-by: Chris Broadfoot <cbro@golang.org>
magiconair
added a commit
to fabiolb/fabio
that referenced
this issue
Jan 16, 2017
This patch re-enables the HTTP/2 support for go1.7 and beyond by setting the NextProto field in the custom TLSConfig. See golang/go#15908
magiconair
added a commit
to fabiolb/fabio
that referenced
this issue
Jan 16, 2017
This patch re-enables the HTTP/2 support for go1.7 and beyond by setting the NextProto field in the custom TLSConfig. See golang/go#15908
magiconair
added a commit
to fabiolb/fabio
that referenced
this issue
Jan 16, 2017
This patch re-enables the HTTP/2 support for go1.7 and beyond by setting the NextProto field in the custom TLSConfig. See golang/go#15908
magiconair
added a commit
to fabiolb/fabio
that referenced
this issue
Jan 16, 2017
This patch re-enables the HTTP/2 support for go1.7 and beyond by setting the NextProto field in the custom TLSConfig. See golang/go#15908
magiconair
added a commit
to fabiolb/fabio
that referenced
this issue
Jan 17, 2017
This patch re-enables the HTTP/2 support for go1.7 and beyond by setting the NextProto field in the custom TLSConfig. See golang/go#15908
magiconair
added a commit
to fabiolb/fabio
that referenced
this issue
Jan 17, 2017
This patch re-enables the HTTP/2 support for go1.7 and beyond by setting the NextProto field in the custom TLSConfig. See golang/go#15908
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
From
tls.Confgdocs:But calling Serve will call setupHTTP2, which calls http2ConfigureServer, which will modify the tls.Config. Since by the time you call Serve you must have already called tls.Listen, the immutability promise is broken.
I don't think anything relies on it yet, but nothing stops someone from for example caching the NextProtos in crypto/tls.Listen or something, breaking the setupHTTP2 magic.
The text was updated successfully, but these errors were encountered: