Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: compute builtin import data directly from source files #15839

Closed
griesemer opened this issue May 25, 2016 · 3 comments
Closed

cmd/compile: compute builtin import data directly from source files #15839

griesemer opened this issue May 25, 2016 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.8

Comments

@griesemer
Copy link
Contributor

builtin.go contains the export data for the built-in and unsafe package. It is created by running mkbuiltin.go which runs a special compilation over the sources in the builtin directory and then extracts the export data.

A change to the export data format requires a careful multi-step process to update the data in builtin.go; see issue #15835.

Investigate generation of the builtin and unsafe package export data directly from the source files (they are small). This would eliminate the need for builtin.go and mkbuiltin.go and corresponding tests and make it much easier to play with export format changes.
@griesemer griesemer self-assigned this May 25, 2016
@griesemer griesemer added this to the Go1.8Maybe milestone May 25, 2016
@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 10, 2016
@rsc
Copy link
Contributor

rsc commented Oct 20, 2016

Bumping priority here. Not sure if @griesemer or @mdempsky is the one working on it.

@rsc rsc modified the milestones: Go1.8, Go1.8Maybe Oct 20, 2016
@griesemer
Copy link
Contributor Author

This is now a duplicate of #17508 which has been fixed.

@griesemer
Copy link
Contributor Author

https://go-review.googlesource.com/c/31433/ removed the need to handle the unsafe package via builtin.go.

https://go-review.googlesource.com/c/31493/ generates builtin.go directly from the source and uses the go/* libs to do so.

@golang golang locked and limited conversation to collaborators Oct 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.8
Development

No branches or pull requests
4 participants
@rsc @quentinmit @griesemer @gopherbot