Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http2: allow http scheme for http2 #15830

Closed
ayanamist opened this issue May 25, 2016 · 1 comment
Closed

x/net/http2: allow http scheme for http2 #15830

ayanamist opened this issue May 25, 2016 · 1 comment
Labels
FrozenDueToAge

Comments

@ayanamist
Copy link

Previous discussion: #14141
I'm working on a RPC system like gRPC, so we need simple h2c without upgrade request while assuming both client and server support h2c only.
Existing http2 code already has the ability to support this, only https scheme limitation should be loosen.
@gopherbot
Copy link

CL https://golang.org/cl/23181 mentions this issue.

@ayanamist ayanamist mentioned this issue Sep 28, 2016
Closed
@golang golang locked and limited conversation to collaborators May 25, 2017
c3mb0 pushed a commit to c3mb0/net that referenced this issue Apr 2, 2018
@ayanamist @adg
http2: allow http scheme for http2
1082832 
The existing transport implementation limit scheme to https, so
simple h2c can not be used, if we loose the limit to http scheme,
it works well with existing h2c server support.

Fixes golang/go#15830

Change-Id: Icfe65d72b3e6fb41f69019539fb5b86144814378
Reviewed-on: https://go-review.googlesource.com/23181
Reviewed-by: Andrew Gerrand <adg@golang.org>
Run-TryBot: Andrew Gerrand <adg@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ayanamist @gopherbot