You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Go 1.7 added the option to generate trace/pprof files with symbols annotations, so the trace help reads:
[pkg.test] argument is required for traces produced by Go 1.6 and below.
Go 1.7 does not require the binary argument.
However, if a trace/pprof generated with Go 1.6 and no binary are supplied to the tool, no error is shown. Instead, the output is simply broken (the profiles are all one empty node, for example).
cmd/trace and cmd/pprof should check if the trace/pprof has annotations, and if not require the binary to be supplied.
The text was updated successfully, but these errors were encountered:
#10863 tracks this for cmd/pprof already, and a fix (https://golang.org/cl/23323/) was just mailed for that. (Although it only adds a warning; an error might be better.)
Go 1.7 added the option to generate trace/pprof files with symbols annotations, so the
trace
help reads:However, if a trace/pprof generated with Go 1.6 and no binary are supplied to the tool, no error is shown. Instead, the output is simply broken (the profiles are all one empty node, for example).
cmd/trace and cmd/pprof should check if the trace/pprof has annotations, and if not require the binary to be supplied.
The text was updated successfully, but these errors were encountered: