You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The safemode bit is now in the file header. Space for the flag is still present but ignored (see bimport.go, bexport.go). Remove the encoding altogether.
The text was updated successfully, but these errors were encountered:
Ignore respective bit in export data, but leave the info to
minimize format changes for 1.7. Scheduled to remove by 1.8.
For #15772.
Change-Id: Ifb3beea655367308a4e2d5dc8cb625915f904287
Reviewed-on: https://go-review.googlesource.com/23285
Run-TryBot: Robert Griesemer <gri@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
What's the rationale for leaving the safemode bit in 1.7's binary encoding? Just don't want to have to update go/internal/gcimporter and x/tools/go/gcimporter15 again?
Fine to rip out with some larger change, but when we do that, there's a few
more cleanups that I want to do. Also, updating builtin.go is always a bit
tricky since we need to read it (old format) and then write it (new
format), and then update the compiler to read the new format.
What's the rationale for leaving the safemode bit in 1.7's binary
encoding? Just don't want to have to update go/internal/gcimporter https://goto.google.com/internal/gcimporter and x/tools/go/gcimporter15
again?
—
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub #15772 (comment)
The safemode bit is now in the file header. Space for the flag is still present but ignored (see bimport.go, bexport.go). Remove the encoding altogether.
The text was updated successfully, but these errors were encountered: