Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: don't encode safemode bit in binary export format anymore #15772

Closed
griesemer opened this issue May 20, 2016 · 3 comments
Closed

cmd/compile: don't encode safemode bit in binary export format anymore #15772

griesemer opened this issue May 20, 2016 · 3 comments
Labels
FrozenDueToAge
Milestone
Go1.8

Comments

@griesemer
Copy link
Contributor

The safemode bit is now in the file header. Space for the flag is still present but ignored (see bimport.go, bexport.go). Remove the encoding altogether.
@griesemer griesemer added this to the Go1.8 milestone May 20, 2016
@griesemer griesemer self-assigned this May 20, 2016
@gopherbot
Copy link

CL https://golang.org/cl/23285 mentions this issue.

gopherbot pushed a commit that referenced this issue May 20, 2016
@griesemer
cmd/compile: read safemode bit from package header
054a721 
Ignore respective bit in export data, but leave the info to
minimize format changes for 1.7. Scheduled to remove by 1.8.

For #15772.

Change-Id: Ifb3beea655367308a4e2d5dc8cb625915f904287
Reviewed-on: https://go-review.googlesource.com/23285
Run-TryBot: Robert Griesemer <gri@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
@mdempsky
Copy link
Member

What's the rationale for leaving the safemode bit in 1.7's binary encoding? Just don't want to have to update go/internal/gcimporter and x/tools/go/gcimporter15 again?

@griesemer
Copy link
Contributor Author

Yes - minimal change.

Fine to rip out with some larger change, but when we do that, there's a few
more cleanups that I want to do. Also, updating builtin.go is always a bit
tricky since we need to read it (old format) and then write it (new
format), and then update the compiler to read the new format.

  • gri

On Fri, May 20, 2016 at 2:48 PM, Matthew Dempsky notifications@github.com
wrote:

What's the rationale for leaving the safemode bit in 1.7's binary
encoding? Just don't want to have to update go/internal/gcimporter
https://goto.google.com/internal/gcimporter and x/tools/go/gcimporter15
again?

—
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
#15772 (comment)

@golang golang locked and limited conversation to collaborators Aug 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.8
Development

No branches or pull requests
3 participants
@mdempsky @griesemer @gopherbot