New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/http: interface-like Transport.Dial being deprecated in favor of concrete *net.Dialer Transport.Dialer #15748
Comments
And even while Transport.Dial remains as-is there will be no way for a non-*net.Dialer to receive context since that is only used with Transport.Dialer. cc @bradfitz |
Ping @bradfitz |
Sorry, I've been rushing to finish my Go 1.7 bugs before I disappear on vacation for a month. That month begins approximately 15 minutes ago. I'll leave this to others. |
Happy to submit a CL for this if we can decide on a solution. |
It seems like it should be a DialContext func, to match the previous Dial func. |
Sounds good, I should be able to get a CL together later today. On Friday, 27 May 2016, Russ Cox notifications@github.com wrote:
|
@dpiddy, I'm heading out soon and want to get this in, so I'll write the CL. I'll make sure you are on it. Thanks. |
CL https://golang.org/cl/23489 mentions this issue. |
Thanks! |
In 5855905 the interface-like Transport.Dial was deprecated for a new Transport.Dialer which is a concrete *net.Dialer.
I understand Transport.Dial will remain but as seen in #12737 and #14221 it might be preferable in the long run to use something interface-based. Only DialContext is used on the new Transport.Dialer.
Before this goes out in 1.7 would it be worthwhile to change from a concrete *net.Dialer to either:
The text was updated successfully, but these errors were encountered: