New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/http: TestTransportEventTrace_h2 fails with "expected substring "WroteRequest: {Err:<nil>}" in output." #15744
Labels
Milestone
Comments
Not only dragonfly but linux-ppc64le-buildlet: |
and linux-amd64-nocgo: |
mikioh
changed the title
net/http: TestTransportEventTrace_h2 fails with empty httptrace.GotConnInfo
net/http: TestTransportEventTrace_h2 fails with "expected substring "WroteRequest: {Err:<nil>}" in output."
May 19, 2016
I have a fix. |
CL https://golang.org/cl/23254 mentions this issue. |
CL https://golang.org/cl/23235 mentions this issue. |
gopherbot
pushed a commit
to golang/net
that referenced
this issue
May 20, 2016
In Go 1.6, the HTTP/1 client got Transport.ExpectContinueTimeout. This makes the HTTP/2 client respect a Request's "Expect: 100-continue" field and the Transport.ExpectContinueTimeout configuration. This also makes sure to call the traceWroteRequest hook if the server replied while we're still writing the request, since that code was in the same spot and it couldn't be trivially separated. Updates golang/go#13851 (fixed after integrating it into std) Updates golang/go#15744 Change-Id: I67dfd68532daa6c4a0c026549c6e5cbfce50e1ea Reviewed-on: https://go-review.googlesource.com/23235 Reviewed-by: Andrew Gerrand <adg@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
See https://build.golang.org/log/641eac826e7b0a6183e1b0ce7c6bb75e572c73e0
Looks like netDial succeeds but httptrace.GotConnInfo is empty, strange.
The text was updated successfully, but these errors were encountered: