Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strings: assembly optimization causes regression in functionality #15679

Closed
dsnet opened this issue May 13, 2016 · 4 comments
Closed

strings: assembly optimization causes regression in functionality #15679

dsnet opened this issue May 13, 2016 · 4 comments
Labels
FrozenDueToAge
Milestone
Go1.7

Comments

@dsnet
Copy link
Member

dsnet commented May 13, 2016 •
edited

Commit 6b02a19 caused a regression in the strings package that causes some tests to fail.

A simple test to exercise this behavior is the following:

strings.Contains("abcdef?v=profileM", "abcdef?v=profile&")

On go1.6, this returns false as expected.
On 6b02a19, this returns true, which is incorrect.

/cc @rsc, @TocarIP, @nigeltao
@dsnet dsnet added this to the Go1.7 milestone May 13, 2016
@bradfitz
Copy link
Contributor

/cc @randall77 too

@gopherbot
Copy link

CL https://golang.org/cl/23106 mentions this issue.

@minux
Copy link
Member

minux commented May 15, 2016 via email

@randall77
Copy link
Contributor

I'll open a separate issue.

@randall77 randall77 mentioned this issue May 15, 2016
Closed
@golang golang locked and limited conversation to collaborators May 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.7
Development

No branches or pull requests
5 participants
@bradfitz @minux @dsnet @randall77 @gopherbot