Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database/sql: maxBadConnRetries is hard coded but not configurable #15608

Closed
xiezhenye opened this issue May 9, 2016 · 6 comments
Closed

database/sql: maxBadConnRetries is hard coded but not configurable #15608

xiezhenye opened this issue May 9, 2016 · 6 comments
Labels
FeatureRequest FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.9

Comments

@xiezhenye
Copy link

In database/sql, maxBadConnRetries is hard coded but not configurable.

Sometimes I do not want it to retry when connect fails, or more retry times is required.
@gopherbot
Copy link

CL https://golang.org/cl/22937 mentions this issue.

@bradfitz bradfitz changed the title In database/sql, maxBadConnRetries is hard coded but not configurable database/sql: maxBadConnRetries is hard coded but not configurable May 9, 2016
@bradfitz bradfitz added this to the Go1.8Maybe milestone May 9, 2016
@gopherbot
Copy link

CL https://golang.org/cl/22965 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/22968 mentions this issue.

xiezhenye added a commit to xiezhenye/go that referenced this issue Jun 29, 2016
@xiezhenye
database/sql: add SetMaxBadConnRetries to *DB, make maxBadConnRetries…
0006825 
… configurable.

Currently, in database/sql, maxBadConnRetries is hard coded but not configurable.

Sometimes I do not want it to retry when connect fails, or more retry times is required.

Fixes golang#15608
@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 10, 2016
@gopherbot
Copy link

CL https://golang.org/cl/31140 mentions this issue.

@rsc
Copy link
Contributor

rsc commented Oct 17, 2016

@xiezhenye, why do you want to configure this? Can you say more about the context in which that makes sense and what behavior you want?

@rsc rsc modified the milestones: Go1.9, Go1.8Maybe Oct 20, 2016
@bradfitz
Copy link
Contributor

Timed out. Closing this.

@golang golang locked and limited conversation to collaborators Nov 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
6 participants
@bradfitz @rsc @quentinmit @kardianos @xiezhenye @gopherbot