-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: cannot use &autotmp_1621 (type *error) as type *parseError in argument to runtime.assertE2T2 #15602
Comments
This worked with Friday's tip (+83676d6) but now fails nicely for me. |
That sure suggests 9d7c9b4 |
Given that the bug that that CL was fixing is not a regression from 1.6 (it was broken in 1.5 and 1.6), and given Russ's instructions for the code freeze, I suggest we re-open that issue, roll back the buggy fix, add a test case from this issue (closing it in the process), and then re-fix during the 1.8 cycle. |
Agreed with @josharian. Revert 9d7c9b4 for 1.7, and try again for 1.8. In retrospect, I suspect the issue is just the temporary variables need to match the RHS's type, not the LHS's type, but I don't want to try to roll forward with the problem now. Minimal repro:
|
CL https://golang.org/cl/22930 mentions this issue. |
This reverts commit 9d7c9b4. For #15602. Change-Id: I464184b05babe4cb8dedab6161efa730cea6ee2d Reviewed-on: https://go-review.googlesource.com/22930 Run-TryBot: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
Reverted. |
I think this should be closed by a CL adding the minimal reproduction case you identified. That test will pass, and will prevent regression. |
I'll mail such a CL in a bit if you don't beat me to it. |
SGTM, go for it. |
CL https://golang.org/cl/22931 mentions this issue. |
The problem was fixed by the rollback in CL 22930. This CL just adds a test to prevent regressions. Fixes golang#15602 Change-Id: I37453f6e18ca43081266fe7f154c6d63fbaffd9b
See failed Travis build for Viper:
https://travis-ci.org/spf13/viper/jobs/128640109
Works on 1.4-1.6, fails on Go tip.
See https://github.com/BurntSushi/toml/blob/master/parse.go#L43
The text was updated successfully, but these errors were encountered: