Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

archive/tar: PAX does not take precedence over USTAR #15564

Closed
dsnet opened this issue May 6, 2016 · 1 comment
Closed

archive/tar: PAX does not take precedence over USTAR #15564

dsnet opened this issue May 6, 2016 · 1 comment
Labels
FrozenDueToAge
Milestone
Go1.8Maybe

Comments

@dsnet
Copy link
Member

dsnet commented May 6, 2016

Using go1.6

According to PAX standard, PAX fields take precedence over USTAR fields. Thus, if the file size fields from USTAR and PAX differ, PAX should take precedence. This is especially critical for large file support with PAX.

Example:
https://play.golang.org/p/Oxk0gb-yoC
@dsnet dsnet mentioned this issue May 6, 2016
Closed
@dsnet dsnet self-assigned this May 9, 2016
@dsnet dsnet added this to the Go1.8Maybe milestone May 9, 2016
@gopherbot
Copy link

CL https://golang.org/cl/27454 mentions this issue.

gopherbot pushed a commit that referenced this issue Aug 25, 2016
@dsnet
archive/tar: isolate regular and sparse file handling as methods
6af7639 
Factor out the regular file handling logic into handleRegularFile
from nextHeader. We will need to reuse this logic when fixing #15573
in a future CL.

Factor out the sparse file handling logic into handleSparseFile.
Currently this logic is split between nextHeader (for GNU sparse
files) and Next (for PAX sparse files). Instead, we move this
related code into a single method.

There is no overall logic change. Thus, no unit tests.

Updates #15573 #15564

Change-Id: I3b8270d8b4e080e77d6c0df6a123d677c82cc466
Reviewed-on: https://go-review.googlesource.com/27454
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Sep 2, 2017
@rsc rsc unassigned dsnet Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.8Maybe
Development

No branches or pull requests
2 participants
@dsnet @gopherbot