Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: mips64 backend does not handle large uint->float conversion correctly #15552

Closed
cherrymui opened this issue May 5, 2016 · 2 comments
Closed

cmd/compile: mips64 backend does not handle large uint->float conversion correctly #15552

cherrymui opened this issue May 5, 2016 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.7

Comments

@cherrymui
Copy link
Member

It uses the same algorithm as ppc64 backend before CL 22772 (issue #15539).

See builder failure https://build.golang.org/log/41fbe7202473255b83ebaad0203811f42a0e91e4
@cherrymui cherrymui added this to the Go1.7 milestone May 5, 2016
@cherrymui cherrymui self-assigned this May 5, 2016
@gopherbot
Copy link

CL https://golang.org/cl/22800 mentions this issue.

gopherbot pushed a commit that referenced this issue May 5, 2016
@cherrymui
cmd/compile/internal/gc: skip TestFP on mips64x
6ccab44 
The legacy mips64 backend doesn't handle large uint->float conversion
correctly. See #15552.

Change-Id: I84ceeaa95cc4e85f09cc46dfb30ab5d151f6b205
Reviewed-on: https://go-review.googlesource.com/22800
Reviewed-by: Minux Ma <minux@golang.org>
@dr2chase dr2chase mentioned this issue May 5, 2016
Closed
@gopherbot
Copy link

CL https://golang.org/cl/22835 mentions this issue.

@golang golang locked and limited conversation to collaborators May 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.7
Development

No branches or pull requests
2 participants
@gopherbot @cherrymui