New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: revisit tag selection on 'go get' #15533
Comments
Actually, this is the only rule. |
At this point, I'd be very happy if it gets removed. I currently see very little use/benefit from that additional rule, but it does increase complexity (amount of things to keep in one's mind, implement in other tools, etc.). Of course, I'm open to hearing arguments why it's useful, but so far I am unaware of any. |
I thought there was more here when I suggested removing it. It may be that there's not enough here to worry about. But I'd still like to see stats about how many Go repos on Github have a go1 revision (tag or branch). |
@rsc I had run out of quota, however the query shows only 937 files that pointing to refs that named "go1" |
At the time of checking, there were 46670 Go repositories on GitHub listed at godoc.org, with the following stats for
The repositories were obtained by |
According to the BigQuery's public GitHub data set, what's below are the only repos with a go1 branch. Beware that some of the items on the list are just forks.
|
It appears that the selection of local version string is a little loose. I have a user who has found that go get for biogo/biogo fails because it tries to checkout the go1 tagged commit - this happens for go1.7.4 and go1.8rc1. I can remove the tag, but this behaviour seems counter to this #15533 (comment)"
|
Obsoleted by modules, thank goodness. |
The docs say:
This is very poorly specified (if you have 1.6.2 and there's a
1.6
git tag, do you get the tagged revision?) and I'm not sure that it's useful. We should figure out whether people are using it and consider removing it entirely.cc @rsc
The text was updated successfully, but these errors were encountered: