Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: add SSA check that memory args are always last #15510

Closed
josharian opened this issue May 2, 2016 · 2 comments
Closed

cmd/compile: add SSA check that memory args are always last #15510

josharian opened this issue May 2, 2016 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.7

Comments

@josharian
Copy link
Contributor

tighten (and maybe other passes?) assume that if a value v has a memory arg, it will be the last one. This convention is not checked anywhere that I see.

@randall77 should we enforce this during the ssa check? Should we do this for 1.7?
@randall77
Copy link
Contributor

Yes, we can and should check this for 1.7.

@josharian josharian added this to the Go1.7 milestone May 3, 2016
@josharian josharian self-assigned this May 3, 2016
@gopherbot
Copy link

CL https://golang.org/cl/22784 mentions this issue.

@golang golang locked and limited conversation to collaborators May 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.7
Development

No branches or pull requests
3 participants
@josharian @randall77 @gopherbot