Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/pprof: very fat arrows in output #15500

Closed
jmhodges opened this issue Apr 30, 2016 · 8 comments
Closed

cmd/pprof: very fat arrows in output #15500

jmhodges opened this issue Apr 30, 2016 · 8 comments
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone

Comments

@jmhodges
Copy link
Contributor

jmhodges commented Apr 30, 2016

Please answer these questions before submitting your issue. Thanks!

  1. What version of Go are you using (go version)?

go version go1.6.2 darwin/amd64

  1. What operating system and processor architecture are you using (go env)?

darwin/amd64

  1. What did you do?

Ran go tool pprof -base ./howsmyssl-1.heap -inuse_objects and then web. Then also, -png from the command line. This is with graphviz 2.38.0_3 installed via MacPorts.

When doing so, my arrows are often very fat, sometimes to the point of obscuring the boxes they connect.

The most egregious of these I caught as an SVG and is here (github won't allow the upload directly on this ticket): https://gist.github.com/jmhodges/72869f007b58f527595766487add4af0

Here is a less obvious example that I managed to capture as a PNG. fairlyfatarrows

@bradfitz
Copy link
Contributor

That's kinda neat, actually. I'd never seen that.

@bradfitz bradfitz changed the title very fat arrows in pprof output cmd/pprof: very fat arrows in output Apr 30, 2016
@bradfitz bradfitz added this to the Unplanned milestone Apr 30, 2016
@robpike
Copy link
Contributor

robpike commented Apr 30, 2016

That's working as intended, I think. Dominant flow is indicated by much ink.

You say it obscures the text in the boxes but I see no evidence of that.

@jmhodges
Copy link
Contributor Author

Here's a screenshot of the SVG. It demonstrates the obscuring of text.

screen shot 2016-04-30 at 4 52 19 pm

@bradfitz
Copy link
Contributor

Yeah, that might be a little excessive.

@jmhodges
Copy link
Contributor Author

jmhodges commented Apr 30, 2016

Yeah, once you start looking, you notice the even the arrows in the PNG overlap the "4xxxxx"s right down the middle of the screen, which could suck if they were really "14xxxx" or whatever. So a max thickness would get this pretty far, but it might also need some overlap prevention depending on how the arrows are laid out with the text. ¯_(ツ)_/¯

@griesemer
Copy link
Contributor

The good news is there's some well identified serious hot spot... :-)

On Sat, Apr 30, 2016 at 4:59 PM, Jeff Hodges notifications@github.com
wrote:

Yeah, once you start looking, you notice the even the arrows in the PNG
overlap the "4xxxxx"s right down the middle of the screen, which could suck
if they were really "14xxxx" or whatever. So a max thickness would get this
pretty far, but it might also need some overlap prevention depending on how
the arrows are laid out with the text.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#15500 (comment)

@ALTree
Copy link
Member

ALTree commented Jul 18, 2017

@jmhodges Is this still an issue? Can you reproduce this with go1.9 (after the pprof update from upstream)?

@ALTree ALTree added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Jul 18, 2017
@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@golang golang locked and limited conversation to collaborators Aug 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Development

No branches or pull requests

6 participants