-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/pprof: very fat arrows in output #15500
Comments
That's kinda neat, actually. I'd never seen that. |
That's working as intended, I think. Dominant flow is indicated by much ink. You say it obscures the text in the boxes but I see no evidence of that. |
Yeah, that might be a little excessive. |
Yeah, once you start looking, you notice the even the arrows in the PNG overlap the "4xxxxx"s right down the middle of the screen, which could suck if they were really "14xxxx" or whatever. So a max thickness would get this pretty far, but it might also need some overlap prevention depending on how the arrows are laid out with the text. ¯_(ツ)_/¯ |
The good news is there's some well identified serious hot spot... :-) On Sat, Apr 30, 2016 at 4:59 PM, Jeff Hodges notifications@github.com
|
@jmhodges Is this still an issue? Can you reproduce this with go1.9 (after the pprof update from upstream)? |
Timed out in state WaitingForInfo. Closing. (I am just a bot, though. Please speak up if this is a mistake or you have the requested information.) |
Please answer these questions before submitting your issue. Thanks!
go version
)?go version go1.6.2 darwin/amd64
go env
)?darwin/amd64
Ran
go tool pprof -base ./howsmyssl-1.heap -inuse_objects
and thenweb
. Then also,-png
from the command line. This is with graphviz 2.38.0_3 installed via MacPorts.When doing so, my arrows are often very fat, sometimes to the point of obscuring the boxes they connect.
The most egregious of these I caught as an SVG and is here (github won't allow the upload directly on this ticket): https://gist.github.com/jmhodges/72869f007b58f527595766487add4af0
Here is a less obvious example that I managed to capture as a PNG.
The text was updated successfully, but these errors were encountered: