New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
godoc chokes on symlink #1540
Labels
Comments
path.Walk doesn't follow symlinks, and I understand that this is to avoid circular behaviour. I'm not sure where the fix is, if any. Godoc could kick off an additional Walk when its VisitFile encounters a symlink'd directory. Or path.Walk could have an option to follow symlinks. Or we could mandate that the goroot be intact and free of symlinks for our tools to work. To solve this specific problem, why not make /usr/share/godoc/src a symlink to /usr/lib/golang/src ? Owner changed to a...@golang.org. Status changed to Thinking. |
> Godoc could kick off an additional Walk when its VisitFile encounters a symlink'd directory. That would probably be the best sollution (with limiting max depth to something like 3 or 5). But the easies workaround would be to resolve the symlink on the first level (ie. just resolve the /usr/lib/golang/src and run path.Walk inside the resolved path). > To solve this specific problem, why not make /usr/share/godoc/src a symlink to /usr/lib/golang/src ? It links to #1539 (ie. architecture-independent files should be in /usr/share/<something>). |
> If you stop letting yourself get pushed around by FHS > you will be happier. The thing is not being pushed by FHS but it's either go will be included in major distributions like Debian (aka FHS) or not (no FHS support). Anyway no hard feelings, I'll fix it myself just for Debian (and other distros could pick it up from my git repo). |
A very minor clash with my development practice encountered this same problem. I like to do ln -s ~/src/gostuff ~/go/src/pkg/bitbucket/ww and of course that breaks godoc. As I said a minor inconvenience - to check the documentation I have to push to bitbucket and then install with goinstall. A patch to fix this in godoc is attached but "go doesn't support symlinks in directory hierarchies" sounds rather categorical... Attachments:
|
Comment 7 by dmitry@dsa.pp.ru: I've got another patch to fix the problem. Attachments:
|
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The text was updated successfully, but these errors were encountered: