-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sha3: previous alignment change should be ppc64le only #15392
Labels
Comments
CL https://golang.org/cl/22323 mentions this issue. |
c-expert-zigbee
pushed a commit
to c-expert-zigbee/crypto_go
that referenced
this issue
Mar 28, 2022
A previous fix to improve performance based on alignment to sha3 was made in both ppc64le and ppc64, when it should have only applied to ppc64le. This changes the build tags so it is only done for ppc64le. Fixes golang/go#15392 Change-Id: Idf32a0370f3c76fc2b54a2897a668acbae5d43c5 Reviewed-on: https://go-review.googlesource.com/22323 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
c-expert-zigbee
pushed a commit
to c-expert-zigbee/crypto_go
that referenced
this issue
Mar 29, 2022
A previous fix to improve performance based on alignment to sha3 was made in both ppc64le and ppc64, when it should have only applied to ppc64le. This changes the build tags so it is only done for ppc64le. Fixes golang/go#15392 Change-Id: Idf32a0370f3c76fc2b54a2897a668acbae5d43c5 Reviewed-on: https://go-review.googlesource.com/22323 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
LewiGoddard
pushed a commit
to LewiGoddard/crypto
that referenced
this issue
Feb 16, 2023
A previous fix to improve performance based on alignment to sha3 was made in both ppc64le and ppc64, when it should have only applied to ppc64le. This changes the build tags so it is only done for ppc64le. Fixes golang/go#15392 Change-Id: Idf32a0370f3c76fc2b54a2897a668acbae5d43c5 Reviewed-on: https://go-review.googlesource.com/22323 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
BiiChris
pushed a commit
to BiiChris/crypto
that referenced
this issue
Sep 15, 2023
A previous fix to improve performance based on alignment to sha3 was made in both ppc64le and ppc64, when it should have only applied to ppc64le. This changes the build tags so it is only done for ppc64le. Fixes golang/go#15392 Change-Id: Idf32a0370f3c76fc2b54a2897a668acbae5d43c5 Reviewed-on: https://go-review.googlesource.com/22323 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
desdeel2d0m
added a commit
to desdeel2d0m/crypto
that referenced
this issue
Jul 1, 2024
A previous fix to improve performance based on alignment to sha3 was made in both ppc64le and ppc64, when it should have only applied to ppc64le. This changes the build tags so it is only done for ppc64le. Fixes golang/go#15392 Change-Id: Idf32a0370f3c76fc2b54a2897a668acbae5d43c5 Reviewed-on: https://go-review.googlesource.com/22323 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Please answer these questions before submitting your issue. Thanks!
go version
)?go version devel +3e9264c Tue Apr 19 09:21:57 2016 +0000 linux/ppc64
go env
)?go env
GOARCH="ppc64"
GOBIN=""
GOEXE=""
GOHOSTARCH="ppc64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/boger/sha3"
GORACE=""
GOROOT="/home/boger/golang/md5new/go"
GOTOOLDIR="/home/boger/golang/md5new/go/pkg/tool/linux_ppc64"
CC="gcc"
GOGCCFLAGS="-fPIC -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build056218607=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="0"
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
Build the test in golang.org/x/crypto/sha3
PASS
Bad output and FAIL
A recent change to improve performance based on alignment should have only been made on ppc64le, but was made for both ppc64le and ppc64.
The text was updated successfully, but these errors were encountered: