Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: clean up old gcdead flotsam #15377

Closed
josharian opened this issue Apr 19, 2016 · 1 comment
Closed

cmd/compile: clean up old gcdead flotsam #15377

josharian opened this issue Apr 19, 2016 · 1 comment

Comments

@josharian
Copy link
Contributor

In plive.go, we find this comment:

            // In order for GODEBUG=gcdead=1 to work, each bitmap needs
            // to contain information about all variables covered by the bitmap.
            // For local variables, the bitmap only covers the stkptrsize
            // bytes in the frame where variables containing pointers live.
            // For arguments and results, the bitmap covers all variables,
            // so we must include all the variables, even the ones without
            // pointers.

And later:

                // Ambiguously live variables are zeroed immediately after
                // function entry. Mark them live for all the non-entry bitmaps
                // so that GODEBUG=gcdead=1 mode does not poison them.

But gcdead no longer exists. Do we still need these full and marked live bitmaps? If we do, let's update or remove those comments.

See also gcdead-related tests and comments in test/live{,_ssa}.go.

cc @aclements

@josharian josharian added this to the Unreleased milestone Apr 19, 2016
@josharian
Copy link
Contributor Author

Fixed by CL 24896.

@golang golang locked and limited conversation to collaborators Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants