Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: make deadcode pass cheaper and do it after cse #15306

Closed
josharian opened this issue Apr 14, 2016 · 6 comments
Closed

cmd/compile: make deadcode pass cheaper and do it after cse #15306

josharian opened this issue Apr 14, 2016 · 6 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. ToolSpeed
Milestone
Unplanned

Comments

@josharian
Copy link
Contributor

[moved from discussion in CL 21981]

CSE can remove many values, so it'd be good to do a deadcode pass promptly after it, to speed up other passes. We used to, but it has slowly drifted away. However, deadcode allocates some potentially large slices: two work lists (small) and two bool slices (larger). We should make at least those bool slices reusable in f.Config and then add a deadcode after CSE.

cc @tzneal

Btw, @bradfitz, do you think it's worth having a label for compiler performance/speed (as opposed to compiled code performance)?
@josharian josharian added this to the Unplanned milestone Apr 14, 2016
@bradfitz
Copy link
Contributor

We used to have too many labels, so we're trying to make do with fewer these days. But build speed is a focus, so, sure. We can always delete it if unused.

@josharian josharian self-assigned this May 11, 2016
@josharian josharian modified the milestones: Go1.8, Unplanned May 11, 2016
@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 11, 2016
@rsc rsc modified the milestones: Go1.9, Go1.8 Oct 21, 2016
@stemar94
Copy link

stemar94 commented Mar 2, 2017

I uploaded a CL, but I need some assistance in order to properly benchmark the change.

@gopherbot
Copy link

CL https://golang.org/cl/37636 mentions this issue.

@josharian
Copy link
Contributor Author

Please benchmark with godoc.org/rsc.io/compilebench and compare results with https://godoc.org/rsc.io/benchstat.

@josharian josharian mentioned this issue Apr 24, 2017
Open
@josharian josharian modified the milestones: Go1.10, Go1.9 May 2, 2017
@bradfitz bradfitz modified the milestones: Go1.10, Go1.11 Nov 28, 2017
@thanm thanm removed this from the Go1.11 milestone Jun 19, 2018
@thanm
Copy link
Contributor

thanm commented Jun 19, 2018

Seems unlikely to land in Go1.11, updated milestone accordingly.

@ianlancetaylor ianlancetaylor added this to the Unplanned milestone Jul 11, 2018
@gopherbot
Copy link

Change https://golang.org/cl/166718 mentions this issue: cmd/compile: make deadcode pass cheaper

@golang golang locked and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. ToolSpeed
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
8 participants
@bradfitz @josharian @rsc @quentinmit @ianlancetaylor @gopherbot @stemar94 @thanm