-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: make deadcode pass cheaper and do it after cse #15306
Comments
We used to have too many labels, so we're trying to make do with fewer these days. But build speed is a focus, so, sure. We can always delete it if unused. |
I uploaded a CL, but I need some assistance in order to properly benchmark the change. |
CL https://golang.org/cl/37636 mentions this issue. |
Please benchmark with godoc.org/rsc.io/compilebench and compare results with https://godoc.org/rsc.io/benchstat. |
Seems unlikely to land in Go1.11, updated milestone accordingly. |
Change https://golang.org/cl/166718 mentions this issue: |
[moved from discussion in CL 21981]
CSE can remove many values, so it'd be good to do a deadcode pass promptly after it, to speed up other passes. We used to, but it has slowly drifted away. However, deadcode allocates some potentially large slices: two work lists (small) and two bool slices (larger). We should make at least those bool slices reusable in f.Config and then add a deadcode after CSE.
cc @tzneal
Btw, @bradfitz, do you think it's worth having a label for compiler performance/speed (as opposed to compiled code performance)?
The text was updated successfully, but these errors were encountered: