-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/sys/unix: unix.SysctlUint64 fails on 32-bit FreeBSD #15186
Comments
Updates golang/go#15186 Change-Id: I02403cbc9b3f1c786ee8093e1480edff891ecf13 Reviewed-on: https://go-review.googlesource.com/21676 Reviewed-by: Andrew Gerrand <adg@golang.org>
EIO usually indicates an error of "size mismatched" or "unaligned access" to the kernel. I'm not sure why the test uses vm.max_kernel_address. Because vm usually consists of ton of machine-dependent stuff. Also freebsd-386-gce101 is actually a complicated "freebsd-386 on freebsd-amd64" host. It depends on the implementation whether the value is returned from 32-bit kernel part or 64-bit kernel part. It would be better to use more appropriate syscall entry in testing. Also s/TestSysctUint64/TestSysctlUint64 |
|
I guess vm.max_kernel_address is a read-only value inside the kernel, hm, am I missing something?
|
Why do we care whether it's read-only? All we're doing is reading it anyway. |
Nope, I just mentioned it's |
This is a low hanging fruit, https://github.com/golang/sys/blob/master/unix/syscall_bsd.go#L532, for someone who wants to contribute this package. Please don't forget to fix the typos in test functions; s/TestSysct/TestSysctl/g |
CL https://golang.org/cl/36058 mentions this issue. |
The freebsd-386 builder has been failing on this x/sys/unix test for some time now:
https://storage.googleapis.com/go-build-log/68ac1f77/freebsd-386-gce101_03efe3a9.log
/cc @adg @mikioh @minux
The text was updated successfully, but these errors were encountered: