Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: 'go vet' warnings #15177

Closed
valyala opened this issue Apr 7, 2016 · 2 comments
Closed

net/http: 'go vet' warnings #15177

valyala opened this issue Apr 7, 2016 · 2 comments
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Milestone

Comments

@valyala
Copy link
Contributor

valyala commented Apr 7, 2016

go vet in tip reports the following warnings. IMHO, they should be fixed. @bradfitz ?

$ go vet net/http/...
net/http/h2_bundle.go:5013: assignment copies lock value to *cfg: crypto/tls.Config contains sync.Once contains sync.Mutex
net/http/transfer.go:215: net/http/internal.FlushAfterChunkWriter composite literal uses unkeyed fields
exit status 1
net/http/client_test.go:314: missing argument for Fatalf("%T"): format reads arg 1, have only 0 args
net/http/transport_test.go:118: arg c for printf verb %p of wrong type: net.Conn
exit status 1
net/http/httptest/server.go:119: assignment copies lock value to *s.TLS: crypto/tls.Config contains sync.Once contains sync.Mutex
net/http/httptest/server.go:198: arg c for printf verb %p of wrong type: net.Conn
net/http/httptest/httptest_test.go:158: unrecognized printf verb 'i'
net/http/httptest/httptest_test.go:161: unrecognized printf verb 'i'
exit status 1
net/http/httputil/dump_test.go:218: arg body for printf verb %p of wrong type: io.Reader
exit status 1
@bradfitz
Copy link
Contributor

bradfitz commented Apr 7, 2016

Some, but not all.

@bradfitz bradfitz added the Suggested Issues that may be good for new contributors looking for work to do. label Apr 7, 2016
@bradfitz bradfitz added this to the Unplanned milestone Apr 7, 2016
@gopherbot
Copy link

CL https://golang.org/cl/21677 mentions this issue.

gopherbot pushed a commit that referenced this issue Apr 8, 2016
Updates #15177

Change-Id: I748f025461f313b5b426821ead695f90d3011a6b
Reviewed-on: https://go-review.googlesource.com/21677
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Apr 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Development

No branches or pull requests

3 participants