New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: mksyscall_windows.go -systemdll flag generates code that does not build #15167
Comments
CL https://golang.org/cl/21645 mentions this issue. |
I don't think it's worth changing. I think it's fixable with documentation on the existing flags instead. |
Be my guest. Alex |
Should we fix this before you're away? My CL 21645 still stands. Alex PS: I will be traveling until mid June too. |
Also run "go generate" in internal/syscall/windows and internal/syscall/windows/registry Updates #15167 Change-Id: I0109226962f81857fe11d308b869d561ea8ed9f9 Reviewed-on: https://go-review.googlesource.com/23021 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
CL https://golang.org/cl/23022 mentions this issue. |
CL https://golang.org/cl/23023 mentions this issue. |
Updates #15167 Change-Id: I826f67e75011ba79325a1294ac0d70d7c6a3e32f Reviewed-on: https://go-review.googlesource.com/23022 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
Updates golang/go#15167 Change-Id: I58bd7e4e6ba88a2ffba11506e5ac0495de303b5b Reviewed-on: https://go-review.googlesource.com/23023 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
The -systemdll flag says that it should be used if DLLs are to be loaded from Windows system dirctory. And I noticed that golang.org/x/sys/windows/registry "go generate" line does not have that flag. So I tried to add -systemdll flag:
But without success.
Alex
The text was updated successfully, but these errors were encountered: