Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context: TestTimeout is flaky #15158

Closed
bradfitz opened this issue Apr 6, 2016 · 6 comments
Closed

context: TestTimeout is flaky #15158

bradfitz opened this issue Apr 6, 2016 · 6 comments

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Apr 6, 2016

https://storage.googleapis.com/go-build-log/40e67803/openbsd-amd64-gce58_28491a1d.log

--- FAIL: TestTimeout (0.88s)
    context_test.go:235: context should have timed out
FAIL
FAIL    context 5.052s

/cc @mikioh

@bradfitz bradfitz added this to the Unplanned milestone Apr 6, 2016
gopherbot pushed a commit that referenced this issue Apr 6, 2016
Flaky tests are a distraction and cover up real problems.

File bugs instead and mark them as flaky.

This moves the net/http flaky test flagging mechanism to internal/testenv.

Updates #15156
Updates #15157
Updates #15158

Change-Id: I0e561cd2a09c0dec369cd4ed93bc5a2b40233dfe
Reviewed-on: https://go-review.googlesource.com/21614
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/21653 mentions this issue.

gopherbot pushed a commit that referenced this issue Apr 7, 2016
Updates #15158

Change-Id: I53e9e68d36efbf52736822e6caa047cfff501283
Reviewed-on: https://go-review.googlesource.com/21653
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@mikioh mikioh changed the title context: TestTimeout is flaky on OpenBSD context: TestTimeout is flaky Apr 8, 2016
@mikioh
Copy link
Contributor

mikioh commented Apr 8, 2016

@gopherbot
Copy link

CL https://golang.org/cl/21763 mentions this issue.

mk0x9 pushed a commit to mk0x9/go that referenced this issue Apr 8, 2016
Updates golang#15158

Change-Id: Icb3788152a7a5a9b0d56ea38da46d770ffdce413
Reviewed-on: https://go-review.googlesource.com/21763
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
@gopherbot
Copy link

CL https://golang.org/cl/21840 mentions this issue.

@mdempsky
Copy link
Member

I'm under the impression the problem is just the test was sensitive to >100ms spikes of kernel process scheduling latency, which was common on OpenBSD and not impossible on other OSes?

@bradfitz
Copy link
Contributor Author

Correct.

@golang golang locked and limited conversation to collaborators Apr 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants