Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: TestDLLPreloadMitigation leaves garbadge in %TEMP% #15120

Closed
alexbrainman opened this issue Apr 5, 2016 · 3 comments
Closed

runtime: TestDLLPreloadMitigation leaves garbadge in %TEMP% #15120

alexbrainman opened this issue Apr 5, 2016 · 3 comments
Labels
FrozenDueToAge

Comments

@alexbrainman
Copy link
Member 

C:\dev\go\src\runtime>git rev-parse HEAD
fcac88098b1d5eee5f0a546e550c3d95cc13f64b

C:\dev\go\src\runtime>dir %TEMP%
 Volume in drive C has no label.
 Volume Serial Number is 14EE-1A2D

 Directory of C:\Users\brainman\AppData\Local\Temp

05/04/2016  11:18 AM    <DIR>          .
05/04/2016  11:18 AM    <DIR>          ..
31/08/2011  11:03 AM                 0 FXSAPIDebugLogFile.txt
               1 File(s)              0 bytes
               2 Dir(s)   3,344,990,208 bytes free

C:\dev\go\src\runtime>go test -v -run=DLLPreload
=== RUN   TestDLLPreloadMitigation
--- PASS: TestDLLPreloadMitigation (0.69s)
PASS
ok      runtime 0.734s

C:\dev\go\src\runtime>dir %TEMP%
 Volume in drive C has no label.
 Volume Serial Number is 14EE-1A2D

 Directory of C:\Users\brainman\AppData\Local\Temp

05/04/2016  11:18 AM    <DIR>          .
05/04/2016  11:18 AM    <DIR>          ..
31/08/2011  11:03 AM                 0 FXSAPIDebugLogFile.txt
05/04/2016  11:18 AM    <DIR>          TestDLLPreloadMitigation602064551
               1 File(s)              0 bytes
               3 Dir(s)   3,345,580,032 bytes free

C:\dev\go\src\runtime>

Alex
@gopherbot
Copy link

CL https://golang.org/cl/21520 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/21681 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/21698 mentions this issue.

gopherbot pushed a commit that referenced this issue Apr 8, 2016
@alexbrainman @adg
runtime: leave directory before removing it in TestDLLPreloadMitigation
90bf0f1 
Fixes #15120

Change-Id: I1d9a192ac163826bad8b46e8c0b0b9e218e69570
Reviewed-on: https://go-review.googlesource.com/21520
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-on: https://go-review.googlesource.com/21681
Run-TryBot: Andrew Gerrand <adg@golang.org>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
gopherbot pushed a commit that referenced this issue Apr 8, 2016
@alexbrainman @adg
runtime: leave directory before removing it in TestDLLPreloadMitigation
6f643ce 
Fixes #15120

Change-Id: I1d9a192ac163826bad8b46e8c0b0b9e218e69570
Reviewed-on: https://go-review.googlesource.com/21520
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-on: https://go-review.googlesource.com/21698
Run-TryBot: Andrew Gerrand <adg@golang.org>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
@golang golang locked and limited conversation to collaborators Apr 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gopherbot @alexbrainman