Skip to content

runtime: race in BenchmarkChanToSyscallPing1ms #15119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexbrainman opened this issue Apr 5, 2016 · 0 comments
Closed

runtime: race in BenchmarkChanToSyscallPing1ms #15119

alexbrainman opened this issue Apr 5, 2016 · 0 comments

Comments

@alexbrainman
Copy link
Member

1f5b1b2 intoruduced BenchmarkChanToSyscallPing1ms that has a race in it. You can see race on windows-amd64-race builders http://build.golang.org/log/59ecb205a6468221734638127d05f3bf26bb6fba

BenchmarkChanToSyscallPing1ms-4             ==================
WARNING: DATA RACE
Write by goroutine 284:
  testing.(*B).runN()
      C:/workdir/go/src/testing/benchmark.go:135 +0x81
  testing.(*B).launch()
      C:/workdir/go/src/testing/benchmark.go:260 +0x1a8

Previous read by goroutine 1056:
  runtime_test.benchChanToSyscallPing.func1()
      C:/workdir/go/src/runtime/syscall_windows_test.go:910 +0x47

Goroutine 284 (running) created at:
  testing.(*B).doBench()
      C:/workdir/go/src/testing/benchmark.go:228 +0x7a
  testing.(*benchContext).processBench()
      C:/workdir/go/src/testing/benchmark.go:406 +0x2ca
  testing.(*B).run()
      C:/workdir/go/src/testing/benchmark.go:219 +0xb1
  testing.(*B).Run()
      C:/workdir/go/src/testing/benchmark.go:462 +0x3e9
  testing.runBenchmarksInternal.func1()
      C:/workdir/go/src/testing/benchmark.go:378 +0xa7
  testing.(*B).runN()
      C:/workdir/go/src/testing/benchmark.go:139 +0xf3
  testing.runBenchmarksInternal()
      C:/workdir/go/src/testing/benchmark.go:384 +0x725
  testing.(*M).Run()
      C:/workdir/go/src/testing/testing.go:678 +0x2f3
  runtime_test.TestMain()
      C:/workdir/go/src/runtime/crash_test.go:24 +0x39
  main.main()
      runtime/_test/_testmain.go:1060 +0x1a3

Goroutine 1056 (finished) created at:
  runtime_test.benchChanToSyscallPing()
      C:/workdir/go/src/runtime/syscall_windows_test.go:914 +0xad
  runtime_test.BenchmarkChanToSyscallPing1ms()
      C:/workdir/go/src/runtime/syscall_windows_test.go:926 +0x41
  testing.(*B).runN()
      C:/workdir/go/src/testing/benchmark.go:139 +0xf3
  testing.(*B).run1.func1()
      C:/workdir/go/src/testing/benchmark.go:208 +0x64
==================
     300        498015 ns/op

Alex

@golang golang locked and limited conversation to collaborators Apr 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants