New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: silent test failures #15109
Comments
#15654 is an interesting issue. It suggests that the current testing package is able to be a root cause of silent errors mentioned above. We probably need to revisit the use of tester goroutines and defer blocks in test cases. |
@mikioh, interesting indeed. Good connection! |
Waiting for the fix of #15654. |
The fix for #15654 unveils the root cause of silent failures.
A leaked test helper goroutine. |
CL https://golang.org/cl/23742 mentions this issue. |
The net test has been failing silently every few dozen commits on the darwin-* and dragonfly-amd64 builders:
2016-04-03T06:22:07-7c15b2a/dragonfly-amd64
2016-04-03T06:22:07-7c15b2a/darwin-386-10_10
[2016-04-02T02:08:59-6a0bb87/dragonfly-amd64](https://build.golang.org/log/f6860
622974eaf79d09f452a597a1bdfeed9894c)
2016-04-01T22:23:13-59fc42b/dragonfly-amd64
2016-03-31T23:18:24-ec5083e/dragonfly-amd64
[2016-03-31T20:42:02-f5bd355/darwin-amd64-10_10](https://build.golang.org/log/08
fcfca2e6b1380ce88ae03d9f87fa8578e2fb34)
[2016-03-31T06:12:36-a6557a0/dragonfly-amd64](https://build.golang.org/log/0d276
43415c8513a2391f699cb164b285e96e9d1)
[2016-03-30T22:31:07-3efefd9/darwin-amd64-10_10](https://build.golang.org/log/81
f1d8b39f9e849d58dc7c411eb43a75499e0451)
[2016-03-30T22:27:13-d8f1f8d/dragonfly-amd64](https://build.golang.org/log/018ec
8ab2953bd52d9820569072d6d17ebefd3a2)
It also just failed on a trybot: https://storage.googleapis.com/go-build-log/da2905f1/darwin-amd64-10_10_ebfff129.log
The text was updated successfully, but these errors were encountered: