Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/importer: "gccgo importer for custom import path lookup not yet implemented" check inverted #15092

Closed
mwhudson opened this issue Apr 4, 2016 · 1 comment
Milestone

Comments

@mwhudson
Copy link
Contributor

mwhudson commented Apr 4, 2016

Please answer these questions before submitting your issue. Thanks!

  1. What version of Go are you using (go version)?

1.6 and tip

If we look at this bit of code: https://github.com/golang/go/blob/master/src/go/importer/importer.go#L26-L36 you can see that For("compiler", lookup) panics if and only if lookup is nil, which is the wrong way around.

If 1.6 had not been released, this would be a trivial fix. But now that it has, should For continue to accept (and ignore) a lookup function for gccgo?

@bradfitz bradfitz added this to the Go1.7 milestone Apr 7, 2016
@gopherbot
Copy link

CL https://golang.org/cl/21860 mentions this issue.

@golang golang locked and limited conversation to collaborators Apr 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants