x/review/git-codereview: provide a way to configure gerrit URL without codereview.cfg file in the repository #15073
Labels
Milestone
Comments
|
CL https://golang.org/cl/19684 mentions this issue. |
|
Does CL 24001 help with this? |
|
CL https://golang.org/cl/24001 mentions this issue. |
gopherbot
pushed a commit
to golang/review
that referenced
this issue
Jun 14, 2016
Loading codereview.cfg from origin/master effictively means that users have to ask permission to use git-codereview. With this change, users can opt to add the file, .gitignore it, and forget about it. Looking in origin/master also makes it hard to try out git-codereview on a project without having to commit to it. Instead of requiring codereview.cfg be checked in anywhere, just look on the filesystem for it. I can't figure out why I ever thought doing otherwise was a good idea. There are some other related fixes floating around, which might also be good to put in, but this is seems like a good stop-gap, since it is a minimal change; codereview.cfg continues to work for anyone currently using it. Related: golang/go#15616 Related: golang/go#15073 Change-Id: I1e377819f8eb8c8fecf9f022459551a3e8b93d48 Reviewed-on: https://go-review.googlesource.com/24001 Reviewed-by: Andrew Gerrand <adg@golang.org>
|
Closing; I think CL 24001 is a good fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Please answer these questions before submitting your issue. Thanks!
go version)?go version go1.5.3 linux/amd64
go env)?GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/cmdeoliv/go"
GORACE=""
GOROOT="/usr/lib/golang"
GOTOOLDIR="/usr/lib/golang/pkg/tool/linux_amd64"
GO15VENDOREXPERIMENT=""
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0"
CXX="g++"
CGO_ENABLED="1"
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
Trying to use git-codereview with a Gerrit repository that doesn't have codereview.cfg configuration file. It is not always possible to add the file to upstream repository, but git-codereview features that depend on Gerrit could still be used.
git-codereview either provide a way for me to configure the gerrit URL that doesn't depend on the codereview.cfg file being in the repository.
git-codereview doesn't identify my repository as Gerrit, then disable features that depend on Gerrit.
The text was updated successfully, but these errors were encountered: