You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This currently errors with gzip.ErrHeader, but should in fact create a gzip.Reader without issue.
Currently, Go only performs the CRC over the first 10 bytes of the header. However, RFC 1952, section 3.2.3 says:
If FHCRC is set, a CRC16 for the gzip header is present, immediately before the compressed data. The CRC16 consists of the two least significant bytes of the CRC32 for all bytes of the gzip header up to and not including the CRC16.
Instead, we should compute the CRC over the whole header.
The text was updated successfully, but these errors were encountered:
dsnet
changed the title
compress/gzip: Reader incorrect performs FHCRC check
compress/gzip: Reader incorrectly performs FHCRC check
Apr 2, 2016
Using
go1.6
Example code:
This currently errors with
gzip.ErrHeader
, but should in fact create a gzip.Reader without issue.Currently, Go only performs the CRC over the first 10 bytes of the header. However, RFC 1952, section 3.2.3 says:
Instead, we should compute the CRC over the whole header.
The text was updated successfully, but these errors were encountered: