net/http: add customization of proxy CONNECT requests #15027
Comments
|
This proposal is a little confused. It's proposing modifications to Let's discuss your actual needs on the mailing list before jumping to proposals. See https://golang.org/wiki/Questions. |
bradfitz
changed the title
|
Well, I don't make sure but this seems not change of net/url. And maybe simply implementation of Transport.Proxy. package main
import (
"net/http"
"net/url"
)
func main() {
token := "blur"
http.DefaultClient.Transport.(*http.Transport).Proxy = func(r *http.Request) (*url.URL, error) {
r.Header.Add("Authorization", "Bearer " + token)
return r.URL, nil
}
} |
|
@mattn As I mentioned in the mailing-list, the problem is that when you do https, the CONNECT request wraps the original request, and there is no way to attach headers to the CONNECT req |
|
This was added to Go 1.8. See https://beta.golang.org/pkg/net/http/#Transport.ProxyConnectHeader Dup of #13290 |
Please answer these questions before submitting your issue. Thanks!
go version)?1.6
go env)?darwin amd64 [os x]
I tried to use Proxy with a
Bearerauthentication method.Allow other authentication method than Basic HTTP
Proxy authentication is limited to Basic-HTTP-Authentication only, with user & password:
https://github.com/golang/go/blob/master/src/net/http/transport.go#L493
url.URLshould allow custom authentication such asbearerurl.URLshould provide a method that returns the "authentication header value", and do the base64 etc.The text was updated successfully, but these errors were encountered: