Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/ocsp: Should include responderID in parsed Responses #14971

Closed
jsha opened this issue Mar 26, 2016 · 1 comment
Closed

x/crypto/ocsp: Should include responderID in parsed Responses #14971

jsha opened this issue Mar 26, 2016 · 1 comment

Comments

@jsha
Copy link

jsha commented Mar 26, 2016

Per RFC 6960, ResponseData includes ResponderID. It's useful for clients to be able to validate ResponderID against the issuer certificate they are expecting. The Response type should include this field (which may be composite), and ParseResponse should fill it and validate it if provided with an issuer certificate.

@bradfitz bradfitz changed the title ocsp: Should include responderID in parsed Responses x/crypto/ocsp: Should include responderID in parsed Responses Apr 9, 2016
@bradfitz bradfitz added this to the Unreleased milestone Apr 9, 2016
@agl agl self-assigned this Aug 19, 2016
@gopherbot
Copy link

CL https://golang.org/cl/34380 mentions this issue.

@golang golang locked and limited conversation to collaborators Dec 21, 2017
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 28, 2022
ResponderID is unmarshalled into either ResponderName or
ResponderKeyHash depending on which one is present.

Fixes golang/go#14971.

Change-Id: I5ba602753d81835da531321e94898408395068dd
Reviewed-on: https://go-review.googlesource.com/34380
Reviewed-by: Adam Langley <agl@golang.org>
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 29, 2022
ResponderID is unmarshalled into either ResponderName or
ResponderKeyHash depending on which one is present.

Fixes golang/go#14971.

Change-Id: I5ba602753d81835da531321e94898408395068dd
Reviewed-on: https://go-review.googlesource.com/34380
Reviewed-by: Adam Langley <agl@golang.org>
@rsc rsc unassigned agl Jun 23, 2022
jasonwvh pushed a commit to jasonwvh/ocsp that referenced this issue Jul 13, 2022
ResponderID is unmarshalled into either ResponderName or
ResponderKeyHash depending on which one is present.

Fixes golang/go#14971.

Change-Id: I5ba602753d81835da531321e94898408395068dd
Reviewed-on: https://go-review.googlesource.com/34380
Reviewed-by: Adam Langley <agl@golang.org>
LewiGoddard pushed a commit to LewiGoddard/crypto that referenced this issue Feb 16, 2023
ResponderID is unmarshalled into either ResponderName or
ResponderKeyHash depending on which one is present.

Fixes golang/go#14971.

Change-Id: I5ba602753d81835da531321e94898408395068dd
Reviewed-on: https://go-review.googlesource.com/34380
Reviewed-by: Adam Langley <agl@golang.org>
BiiChris pushed a commit to BiiChris/crypto that referenced this issue Sep 15, 2023
ResponderID is unmarshalled into either ResponderName or
ResponderKeyHash depending on which one is present.

Fixes golang/go#14971.

Change-Id: I5ba602753d81835da531321e94898408395068dd
Reviewed-on: https://go-review.googlesource.com/34380
Reviewed-by: Adam Langley <agl@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants