Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gopherbot: include CL name in CL notification comments on issues #14954

Closed
minux opened this issue Mar 25, 2016 · 2 comments
Closed

x/build/cmd/gopherbot: include CL name in CL notification comments on issues #14954

minux opened this issue Mar 25, 2016 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge help wanted
Milestone
Unreleased

Comments

@minux
Copy link
Member

minux commented Mar 25, 2016

The notification issue comment gopherbot add for each CL only
include the CL URL, but for certain issues (like #6853), it's of
not much use because there are so many CLs mentioning the
issue, without the issue title included, the comments are not
that useful.
@minux minux added this to the Unreleased milestone Mar 25, 2016
@ALTree ALTree changed the title gopherbot: include CL name in CL notification comments on issues x/build/cmd/gopherbot: include CL name in CL notification comments on issues Jul 18, 2017
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jul 18, 2017
@ALTree ALTree added help wanted and removed Builders x/build issues (builders, bots, dashboards) labels Jul 18, 2017
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jul 18, 2017
@digitalbytes
Copy link

I looked into this issue because it seemed like a simple place for me to start contributing. After reviewing the code it appears that it may be implemented in https://go-review.googlesource.com/c/51116.

An example of it in the wild can be seen in gopherbot's last comment in this issue: #21392

@josharian
Copy link
Contributor

Indeed; I didn't know an issue existed for this when I implemented CL 51116. Thanks for discovering this—you've contributed now. :)

Happy hunting for your next issue.

@golang golang locked and limited conversation to collaborators Aug 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge help wanted
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@josharian @digitalbytes @minux @ALTree @gopherbot