Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: inconsistency in slice.go #14938

Closed
stemar94 opened this issue Mar 24, 2016 · 2 comments
Closed

runtime: inconsistency in slice.go #14938

stemar94 opened this issue Mar 24, 2016 · 2 comments

Comments

@stemar94
Copy link

In line 87 there stands the following.

if uintptr(newcap) >= _MaxMem/uintptr(et.size) {
    panic(errorString("growslice: cap out of range"))
}

But it should not be compared for >= but only for >, as it is done multiple times in other places in this file.

@stemar94
Copy link
Author

Btw I have a CL for this. I will send shortly.

@ianlancetaylor ianlancetaylor removed their assignment Mar 24, 2016
@gopherbot
Copy link

CL https://golang.org/cl/21046 mentions this issue.

@golang golang locked and limited conversation to collaborators Mar 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants