Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/api: remove contexts slice by parsing go tool dist list -json output #14892

Open
minux opened this issue Mar 21, 2016 · 12 comments
Open

cmd/api: remove contexts slice by parsing go tool dist list -json output #14892

minux opened this issue Mar 21, 2016 · 12 comments
Labels
help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release Team
Milestone
Unplanned

Comments

@minux
Copy link
Member

minux commented Mar 21, 2016

It's discovered in https://golang.org/cl/20935 that cmd/api contains
a copy of supported platforms along with their cgo support status.

We should remove those hardcoded values and use go tool dist list -json
instead.
@minux minux self-assigned this Mar 21, 2016
@minux minux added this to the Go1.7 milestone Mar 21, 2016
@rsc rsc modified the milestones: Go1.8, Go1.7 May 17, 2016
@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 5, 2016
@quentinmit
Copy link
Contributor

@minux Any news on this?

@rsc
Copy link
Contributor

rsc commented Oct 18, 2016

@quentinmit, can you fix this please?

@rsc rsc assigned quentinmit and unassigned minux Oct 18, 2016
@gopherbot
Copy link

CL https://golang.org/cl/31364 mentions this issue.

@quentinmit
Copy link
Contributor

This has become very complicated. I have the patch to do this, but it uncovers years of API diff as a result. I need to improve the api tool's diff algorithm to handle these sanely.

@minux
Copy link
Member Author

minux commented Oct 18, 2016 via email

@bradfitz
Copy link
Contributor

Once you remove the two oddballs which don't matter (nacl and plan9), then there are only a few problems:

-pkg syscall, const O_ASYNC ideal-int  (not in: [solaris-amd64 solaris-amd64-cgo])  
-pkg syscall, const SOCK_DGRAM = 2  (not in: [linux-mips64 linux-mips64-cgo linux-mips64le linux-mips64le-cgo solaris-amd64 solaris-amd64-cgo]) 
-pkg syscall, const SOCK_RAW = 3  (not in: [solaris-amd64 solaris-amd64-cgo])  
-pkg syscall, const SOCK_SEQPACKET = 5  (not in: [solaris-amd64 solaris-amd64-cgo]) 
-pkg syscall, const SOCK_STREAM = 1  (not in: [linux-mips64 linux-mips64-cgo linux-mips64le linux-mips64le-cgo solaris-amd64 solaris-amd64-cgo])  
-pkg syscall, func Utimes(string, []Timeval) error  (not in: [solaris-amd64 solaris-amd64-cgo])

Looks easy enough to fix.

@gopherbot
Copy link

CL https://golang.org/cl/31446 mentions this issue.

gopherbot pushed a commit that referenced this issue Oct 19, 2016
@bradfitz
syscall: make Utimes on Solaris match all the other geese
1e3dc3d 
Updates #14892

Change-Id: I640c6e1635ccdf611f219521a7d297a9885c4cb3
Reviewed-on: https://go-review.googlesource.com/31446
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@quentinmit
Copy link
Contributor

I've updated my CL to include an improved diff algorithm that generates a short(er) diff, and does not report spurious symbol removals for the new GOOS and GOARCH combinations. This means we can include nacl and plan9. PTAL.

@rsc rsc modified the milestones: Go1.8Maybe, Go1.8 Nov 11, 2016
@bradfitz bradfitz mentioned this issue Nov 15, 2016
Closed
@bradfitz bradfitz modified the milestones: Go1.9, Go1.8Maybe Dec 5, 2016
@bradfitz bradfitz modified the milestones: Go1.10, Go1.9 May 23, 2017
@bradfitz bradfitz modified the milestones: Go1.10, Unplanned Nov 15, 2017
@dmitshur dmitshur mentioned this issue Apr 30, 2021
Closed
@cagedmantis cagedmantis added this to Done in Go Release Team May 4, 2021
@cagedmantis cagedmantis moved this from Done to Planned in Go Release Team May 4, 2021
@iwdgo
Copy link
Contributor

iwdgo commented May 24, 2021

The current set of GOOS/GOARCH in cmd/api combines the first class ports, now listed by go tool dist list -json supplemented by a selection:

freebsd/386
freebsd/amd64
freebsd/arm
netbsd/386
netbsd/amd64
netbsd/arm
netbsd/arm64
openbsd/386
openbsd/amd64

Using all existing ports might be very costly. Restricting the run to first class ports seems to fit the purpose of the issue.

@gopherbot
Copy link

Change https://golang.org/cl/322309 mentions this issue: cmd/api: set first class ports as default

@gopherbot
Copy link

Change https://golang.org/cl/342809 mentions this issue: cmd/api: remove default API check for openbsd amd64

@bcmills bcmills mentioned this issue Jun 2, 2022
Open
@gopherbot
Copy link

Change https://go.dev/cl/460536 mentions this issue: cmd/api: run check on first class ports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Status: Planned
Go Release Team
Planned
Milestone
Unplanned
Development

No branches or pull requests
6 participants
@bradfitz @rsc @quentinmit @minux @gopherbot @iwdgo