Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/exp/shiny: windows driver cannot set window height #14879

Closed
200sc opened this issue Mar 19, 2016 · 3 comments
Closed

x/exp/shiny: windows driver cannot set window height #14879

200sc opened this issue Mar 19, 2016 · 3 comments

Comments

@200sc
Copy link

200sc commented Mar 19, 2016

GO/OS info:

Go1.6 windows/amd64
GOARCH = amd64
GOOS = windows

Using x/exp/shiny, we were starting a new project and trying to manipulate the initial window size.

We expected using screen.NewWindowOptions{640,480} to result in a screen of 640 width and 480 height

The screen had no height. See here.

In shiny's windows driver, it sets width to be the option's width, then to be the option's height, without actually ever setting height. This should be a simple fix:

    if opts != nil {
        if opts.Width > 0 {
            w = opts.Width
        }
        if opts.Height > 0 {
            h = opts.Height
        }
    }
@200sc 200sc changed the title x/exp/shiny x/exp/shiny Windows driver cannot set window height Mar 19, 2016
@alexbrainman
Copy link
Member

Silly mistake. @Sythe2o0, please, try https://go-review.googlesource.com/20862 to see if it fixes your problem. Thank you.

Alex

@alexbrainman alexbrainman changed the title x/exp/shiny Windows driver cannot set window height x/exp/shiny: windows driver cannot set window height Mar 20, 2016
@gopherbot
Copy link

CL https://golang.org/cl/20862 mentions this issue.

@200sc
Copy link
Author

200sc commented Mar 20, 2016

That's the same change we made locally, and it did fix it, yes.

@golang golang locked and limited conversation to collaborators Mar 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants