Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/imports: TestFindImportVendor and TestProcessVendor fail #14823

Closed
mwhudson opened this issue Mar 14, 2016 · 3 comments
Closed

x/tools/imports: TestFindImportVendor and TestProcessVendor fail #14823

mwhudson opened this issue Mar 14, 2016 · 3 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@mwhudson
Copy link
Contributor

Please answer these questions before submitting your issue. Thanks!

  1. What version of Go are you using (go version)?

go version devel +c6e8342 Mon Mar 14 14:28:49 2016 +1300 linux/amd64

(but also 1.6)

  1. What operating system and processor architecture are you using (go env)?

linux/amd64

  1. What did you do?

go test golang.org/x/tools/imports

  1. What did you expect to see?

tests passing

  1. What did you see instead?
(master)mwhudson@aeglos:tools$ go test golang.org/x/tools/imports
--- FAIL: TestFindImportVendor (0.05s)
    fix_test.go:909: findImportGoPath("hpack", HuffmanDecode ...)="internal/golang.org/x/net/http2/hpack", false, want "golang.org/x/net/http2/hpack", false
--- FAIL: TestProcessVendor (0.05s)
    fix_test.go:942: Process("/opt/opensource/go/src/math/x.go") did not add expected hpack import:
        package http

        import (
            "strings"

            "internal/golang.org/x/net/http2/hpack"
        )

        func f() { strings.NewReader(); hpack.HuffmanDecode() }
FAIL
FAIL    golang.org/x/tools/imports  0.192s

(this happens on build.golang.org too)
@mwhudson
Copy link
Contributor Author

I think these fail because Go 1.6's stdlib does not, in the end, use any vendoring but this test still assumes they do.

@bradfitz
Copy link
Contributor

It will use vendoring again soon.

@bradfitz bradfitz added this to the Unreleased milestone Apr 9, 2016
@bradfitz
Copy link
Contributor

bradfitz commented Apr 9, 2016

This was fixed recently.

@bradfitz bradfitz closed this as completed Apr 9, 2016
@golang golang locked and limited conversation to collaborators Apr 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @mwhudson @gopherbot