Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: more robust loop entry detector #14789

Closed
randall77 opened this issue Mar 12, 2016 · 1 comment
Closed

cmd/compile: more robust loop entry detector #14789

randall77 opened this issue Mar 12, 2016 · 1 comment
Labels
FrozenDueToAge

Comments

@randall77
Copy link
Contributor

Regalloc currently has a simple loop entry detector. When detected, it loads live values into registers before entering the loop. The detector doesn't always work. In particular, it doesn't work on loops containing other loops. See #14606

We might want a general mechanism in SSA to identify loops. Block.loopDepth maybe, or something more sophisticated.

@dr2chase
@gopherbot
Copy link

CL https://golang.org/cl/20660 mentions this issue.

@golang golang locked and limited conversation to collaborators Mar 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@randall77 @gopherbot